[ENHANCEMENT] Support converting gts files in blueprint#10332
Conversation
|
|
||
| fileInfo.rendered = transformed; | ||
| // removeTypes does not support GTS file format | ||
| if (path.extname(fileInfo.displayPath) === '.ts') { |
There was a problem hiding this comment.
Can this realistically be merged without support? For now it would unblock basic .gts blueprint files that don't contain any types. (e.g. template-only components)
I wonder what the actual support would look like. Should we first transform it to valid TS, remove types, and transform back to GJS?
There was a problem hiding this comment.
I think we'd need a custom parser? or maybe a light process -- like -- extracting the template(s), running babel to remove types, placing the template(s) back
There was a problem hiding this comment.
I've implemented a simple, naive version of extracting the template - removing the types - and placing back the template.
It does the job for simple cases. However, as the removeTypes function from remove-types also does formatting it kind of messes with the replacing. Because of this I'm not confident it would handle every possible case well. But for the sake of blueprints it might be sufficient? (For now?)
IgnaceMaes
changed the title
IgnaceMaes
force-pushed
the
blueprint-gjs-support
branch
from
b013f8c to
26099fc
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Is there any action to take here, or are we just hoping CI will succeed on another retry? 😬 |
|
I think we need to turn of the Merge Queue feature. It doesn't support rerunning failed tests, and we have some flaky windows tests that make it hard to get things through on a single pass. |
3 participants
Add support to convert
.gtsblueprint files to.gjs.Unblocks emberjs/ember.js#20511 (comment)