fix: cppgc crashes on Linux with 16KiB pages#45571
Merged
codebytere merged 1 commit into34-x-yfrom Feb 13, 2025
Merged
Conversation
codebytere
added
semver/patch
deepak1556
approved these changes
Feb 11, 2025
Member
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
The feature seems to be enabled only from 131 https://chromium-review.googlesource.com/c/v8/v8/+/5864909, I think the backports are not needed.
codebytere
removed
the
target/32-x-y
13 tasks
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "33-x-y", please check out #45602 |
trop
Bot
added
in-flight/33-x-y
merged/33-x-y
3 tasks
2 tasks
6 tasks
3 tasks
teutat3s
added a commit
to teutat3s/nixpkgs
that referenced
this pull request
Mar 8, 2025
…s systems Cleanup, because electron 34.3.0 and 33.4.1 already contain the fix upstream and have reached nixpkgs master. https://github.com/electron/electron/releases/tag/v34.3.0 electron/electron#45571 https://github.com/electron/electron/releases/tag/v33.4.1 electron/electron#45602
13 tasks
yuyuyureka
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 12, 2025
…s systems Cleanup, because electron 34.3.0 and 33.4.1 already contain the fix upstream and have reached nixpkgs master. https://github.com/electron/electron/releases/tag/v34.3.0 electron/electron#45571 https://github.com/electron/electron/releases/tag/v33.4.1 electron/electron#45602
sandptel
pushed a commit
to sandptel/nixpkgs
that referenced
this pull request
Mar 13, 2025
…s systems Cleanup, because electron 34.3.0 and 33.4.1 already contain the fix upstream and have reached nixpkgs master. https://github.com/electron/electron/releases/tag/v34.3.0 electron/electron#45571 https://github.com/electron/electron/releases/tag/v33.4.1 electron/electron#45602
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #45560.
Refs https://issues.chromium.org/issues/378017037.
Fixes an issue where Electron may experience crashes on Linux with 16KiB pages. This happened due to hardcoded
kGuardPageSizein cppgc - see above CRBUG for more. Fixed in M134 and above.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Electron may experience crashes on Linux with 16KiB pages.