fix: potential draggable regions crash in DevTools#43179
Merged
codebytere merged 1 commit intomainfrom Aug 5, 2024
Merged
Conversation
codebytere
added
semver/patch
ckerr
approved these changes
Aug 2, 2024
VerteDinde
approved these changes
Aug 2, 2024
|
Release Notes Persisted
|
This was referenced Aug 5, 2024
Contributor
|
I have automatically backported this PR to "32-x-y", please check out #43199 |
trop
bot
added
in-flight/32-x-y
and removed
target/32-x-y
Contributor
|
I have automatically backported this PR to "31-x-y", please check out #43200 |
trop
bot
added
in-flight/31-x-y
and removed
target/31-x-y
Member
|
Thank you for fixing this, @codebytere! 🙌 |
3 tasks
trop
bot
added
merged/31-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #43092
Fix a crash that can occur when
SetSupportsDraggableRegionsis called withtrueand there is noMainFrameImpl. WhenMainFrameImplis nullptr, logic currently correctly returns early, butsupports_draggable_regions_is set before that happens. As a result, whenSupportsDraggableRegions()is called, it will return true, and thusLocalFrameView::UpdateDocumentDraggableRegions()willcall
DraggableRegionsChanged(). This will trigger a crash inWebViewImpl::DraggableRegionsChanged(), as it assumes thatMainFrameImplis not null.Upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/5756619
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that could occur in some DevTools extensions containing draggable regions.