chore: Enable nullable annotations for part of the files #2944
+288
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
force-pushed
the
chore-enable-nullable-5
branch
from
4f0caff to
720fb7f
Compare
filzrev
commented
Dec 27, 2025
| int iterationCount = DefaultValue, | ||
| int invocationCount = DefaultValue, | ||
| string? id = null, | ||
| string id = "", |
Contributor
Author
There was a problem hiding this comment.
This modification don't change existing behaviors.
Because when null or empty string is passed. Id characteristic is not set.
filzrev
commented
Dec 27, 2025
| Environment.NewLine, | ||
| benchmarkCase.Descriptor.WorkloadMethod.GetParameters() | ||
| .Select((parameter, index) => $"private {GetFieldType(parameter.ParameterType, benchmarkCase.Parameters.GetArgument(parameter.Name)).GetCorrectCSharpTypeName()} __argField{index};")); | ||
| .Select((parameter, index) => $"private {GetFieldType(parameter.ParameterType, benchmarkCase.Parameters.GetArgument(parameter.Name!)).GetCorrectCSharpTypeName()} __argField{index};")); |
Contributor
Author
There was a problem hiding this comment.
parameter.Name is ensured to be not null except for return paramenter
filzrev
force-pushed
the
chore-enable-nullable-5
branch
from
720fb7f to
3203b9c
Compare
filzrev
commented
Dec 28, 2025
| yield return RuntimeValidator.DontFailOnError; | ||
| } | ||
|
|
||
| public IOrderer Orderer => null; |
Contributor
Author
There was a problem hiding this comment.
Following property must be nullable.
ArtifactsPathSummaryStyleOrdererCategoryDiscovererCultureInfo
Because it need to represent value is not set.(It's used for merge multiple configs)
filzrev
force-pushed
the
chore-enable-nullable-5
branch
3 times, most recently
from
708b8bd to
fe024d2
Compare
filzrev
force-pushed
the
chore-enable-nullable-5
branch
from
fe024d2 to
b3f8d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix a part issue #2815
By enabling
#nullable enableand fix nullable errors.