CI Auto-Fix

Original PR: #507
Failed CI Run: Non-Main Branch CI/CD

Problem

The TypeScript build failed with a type mismatch error at src/app/[locale]/dashboard/quotas/users/page.tsx:75:

Type error: Type 'number | null' is not assignable to type 'number'.
  Type 'null' is not assignable to type 'number'.

The issue was that:

• getUserLimitUsage action returns limit: number | null (src/actions/users.ts:1235-1236)
• UserQuotaSnapshot type expected limit: number (non-nullable)

This mismatch was introduced by PR #507's changes to support unlimited quotas (represented as null limits).

Fixes Applied

Changed:

export interface UserQuotaSnapshot {
-  rpm: { current: number; limit: number; window: "per_minute" };
-  dailyCost: { current: number; limit: number; resetAt?: Date };
+  rpm: { current: number; limit: number | null; window: "per_minute" };
+  dailyCost: { current: number; limit: number | null; resetAt?: Date };
}

Verification

✅ Type definition now matches the actual return type from getUserLimitUsage
✅ No logic changes - only type definition sync
✅ Safe minimal fix

Notes

This is a safe type synchronization fix. PR #507 explicitly changed quota handling to support null limits (representing unlimited quotas), but the UserQuotaSnapshot type definition wasn't updated accordingly. This PR completes that change by updating the type to match the runtime behavior.

Auto-generated by Claude AI

Greptile Summary

This PR fixes a TypeScript type mismatch by updating UserQuotaSnapshot to allow null limits, matching the return type from getUserLimitUsage which represents unlimited quotas as null values.

Key Changes:

• Updated rpm.limit and dailyCost.limit from number to number | null in UserQuotaSnapshot interface

Critical Issues Found:

• Lines 153 and 176 in user-quota-list-item.tsx don't handle null limits properly when rendering
• When limit is null (unlimited), line 153 displays "null" as text and line 176 calls formatCurrency(null) which returns "$0.00" - both are misleading to users
• These bugs were introduced by the type change but not caught because TypeScript now allows the null values

Impact:
The type fix is correct and necessary, but the UI will display incorrect information for users with unlimited quotas until the display logic is fixed.

Confidence Score: 2/5

• This PR fixes the type error but introduces UI bugs that will display misleading information for unlimited quotas
• The type definition change is correct and necessary to match the data source, but the PR is incomplete - it updates the type without updating the UI components that display those values. Users with unlimited quotas will see "null" or "$0.00" instead of "Unlimited", which is confusing and incorrect.
• src/app/[locale]/dashboard/quotas/users/_components/user-quota-list-item.tsx requires immediate fixes to handle null limits properly

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Page as users/page.tsx
    participant Action as getUserLimitUsage
    participant Type as UserQuotaSnapshot
    participant UI as user-quota-list-item.tsx
    
    Page->>Action: getUserLimitUsage(userId)
    Note over Action: Returns limit as number | null<br/>(null = unlimited quota)
    Action-->>Page: {rpm: {limit: number | null}, dailyCost: {limit: number | null}}
    Page->>Type: Assign to UserQuotaSnapshot
    Note over Type: Before fix: limit: number<br/>After fix: limit: number | null
    Page->>UI: Pass quota data
    Note over UI: Bug: Displays null as "null"<br/>or formats as "$0.00"<br/>Should show "Unlimited"