Enable lazy loading of archivable configurations #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
FranciscoJRSantos
force-pushed
the
feature/enable-proc-password-configurations
branch
from
4647d9a to
bd2e0d4
Compare
olbrich
requested changes
Dec 27, 2024
Contributor
olbrich
left a comment
olbrich
left a comment
There was a problem hiding this comment.
@FranciscoJRSantos Thank you for your contribution! Can you please add a couple of tests for this?
FranciscoJRSantos
force-pushed
the
feature/enable-proc-password-configurations
branch
3 times, most recently
from
52b81bd to
3a6f4a9
Compare
Configurations `password_archiving_count` and `deny_old_passwords` now accept `Proc.new` or `lambda` invocations. This enables the configurations to be loaded during runtime when needed.
FranciscoJRSantos
force-pushed
the
feature/enable-proc-password-configurations
branch
from
d3ed8f6 to
218855b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurations
password_archiving_countanddeny_old_passwordsnow acceptProc.neworlambdainvocations. This enables the configurations to be loaded during runtime when needed.