Skip to content

validValues with strings containing a single quote fail on soda scan #980

@Peterdha

Description

@Peterdha

When using an invalidValues quality metric and provide as validValues a string that contains a single quote char, then the soda scan fails

      - name: LoadProfile_Label
        logicalType: string
        quality:
          - metric: invalidValues
            mustBe: 0
            arguments:
              validValues: ["peter's"]

  |   COUNT(CASE WHEN NOT (LoadProfile_Label IS NULL) AND NOT (LoadProfile_Label IN ('peter's')) THEN 1 END),
  | -------------^^^

would expect to escape it for yaml and sql either using "peter\\\'" or 'peter\''', however none of those seem to work

"peter\\\'" yields:

found unknown escape character "'"
  in "<unicode string>", line 550, column 38:
     ...          validValues: ["peter\\\'"]
                                         ^

'peter\''' yields:

  |   COUNT(CASE WHEN NOT (LoadProfile_Label IS NULL) AND NOT (LoadProfile_Label IN ('peter\\'')) THEN 1 END),
  | -------------^^^

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions