test(e2e): add support for testing different key types, including BLS#3513
Merged
test(e2e): add support for testing different key types, including BLS#3513
Conversation
melekes
reviewed
Jul 13, 2024
to both Sign and VerifySignature https://pkg.go.dev/github.com/cosmos/[email protected]/curves/bls12381#VerifySignature even though Sign doesn't require [32]byte msg, passing arbitrary small messages makes the TestGenPrivKeyFromSecret_SignVerify fail!
As far as I can see there's no reason to use the generated seed from the testnet.go file.
aljo242
pushed a commit
that referenced
this pull request
Sep 4, 2025
…#3513) While working on another crypto to be added to CometBFT, I realised we are not testing other key types in our nightlies, in particular BLS isn't tested. This PR: * adds support for BLS in the runner, generator, and `e2e` tests * adds support for BLS, secp256k1, and ed25519 key types in the `e2e` generator (for the nightlies) * completes support for changing the key type at testnet level. Some support was existing but it wasn't complete (so it didn't work) There is a TODO in the BLS crypto side. I added a temporary workaround and contacted the Zondax folks to include a small patch in `github.com/cosmos/crypto`. If they agree to merge the patch, `GenPrivKeyFromSecret` will become trivial. --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on another crypto to be added to CometBFT, I realised we are not testing other key types in our nightlies, in particular BLS isn't tested.
This PR:
e2etestse2egenerator (for the nightlies)There is a TODO in the BLS crypto side. I added a temporary workaround and contacted the Zondax folks to include a small patch in
github.com/cosmos/crypto. If they agree to merge the patch,GenPrivKeyFromSecretwill become trivial.PR checklist
.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code comments