Skip to content

get_jec_config_default returns str, .load() method used on result #619

@lmoureaux

Description

@lmoureaux

The function columnflow.calibration.cms.jets.get_jerc_file_default returns str:

def get_jerc_file_default(self: Calibrator, external_files: DotDict) -> str:

This function is the default for jec.get_jec_file and jer.get_jer_file.

Further down the code, .load() is called on the result of the get_*_file functions, e.g. for jec:

self.get_jec_file(bundle.files).load(formatter="gzip").decode("utf-8"),

In my recent experience the type hint was right, meaning the defaults do not work 🤔

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions