use correct audience when requesting oidc token#1744
Merged
thomasrockhu-codecov merged 3 commits intocodecov:mainfrom Jan 21, 2025
juho9000:fix/oidc-auth-enterprise
Merged
use correct audience when requesting oidc token#1744thomasrockhu-codecov merged 3 commits intocodecov:mainfrom juho9000:fix/oidc-auth-enterprise
thomasrockhu-codecov merged 3 commits intocodecov:mainfrom
juho9000:fix/oidc-auth-enterprise
Conversation
thomasrockhu-codecov
requested changes
Jan 21, 2025
Contributor
thomasrockhu-codecov
left a comment
thomasrockhu-codecov
left a comment
There was a problem hiding this comment.
Small nit to change the var name, but yeah this looks good, will test it out today
thomasrockhu-codecov
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
1 task
1 task
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audience should be set to the enterprise url if using oidc authentication with it