-
-
Notifications
You must be signed in to change notification settings - Fork 109
Feature refactor wc product filter block integration #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature refactor wc product filter block integration #1140
Conversation
…ct class replacements
Removed mobile dialog display properties and adjusted styles for product filters.
Refactor price slider styles and ensure proper use of !important.
…duct-filter-block Feature: Refactor WC product filter block integration and fix incorrect class replacements
|
I pushed a commit that re-adds the button loader if filter block has active filters. But AJAX cart toast alerts are still not shown if block has active filters (Quantity button alerts works fine). Any idea? |
|
Maybe i found a solution. You can quickly check it here https://dev.bootscore.me/shop/
Let me know what you think... |
…sages-if-WC-product-filter-block-has-active-filters Fix: AJAX-cart toast messages if WC product filter block has active f…
I was analyzing your AJAX-cart update. I think there might still be some missing details. I discovered this by accident because my mouse is double-clicking. The code doesn't seem to prevent multiple clicks (I don't know if this comes from WooCommerce) and ends up generating multiple additions and malfunctioning toasts. multi.clicks.mp4Another issue is that even clicking once (I also tested with my laptop's mousepad), sometimes the toasts don't appear. Perhaps it's the timing of the script's execution. Could you please confirm this? However, I tested it in anonymous mode. possible.inconsistency.mp4 |
Merge `main` into #1140
…https://github.com/bootscore/bootscore into Feature-Refactor-WC-product-filter-block-integration
|
You're right, reverted in e40551a. The toasts will become a challenge... |
@murilocarvalhodev,
created a new branch https://github.com/bootscore/bootscore/tree/Feature-Refactor-WC-product-filter-block-integration and merged your PR into it. New PR is now #1140.
Reason for that is that there is a lot of movement in the main branch right now and its hard to keep your PR branch up-to-date. So, your commits are save. Please update your fork to the latest Bootscore main and submit changes from a new and updated branch to the new PR branch.
Demo: https://dev.bootscore.me/shop/ (Sidebar, works only on shop pages)
Issues
btn-loader50da242Disable the range forms? Changing the value there does nothingNew Filters
Block Widget Styles
Card layout in sidebar