Fix crash when MODULE.bazel has foo = bar.baz()
#1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such assignments don't do anything, but we shouldn't crash on them.
fmeum
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
vladmos
approved these changes
Apr 17, 2024
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Apr 19, 2024
Fixes bazelbuild/buildtools#1263 Closes #22045. PiperOrigin-RevId: 626307672 Change-Id: Ib088e73835ea3d7076976a9de4ab4207ff491b27
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 19, 2024
Fixes bazelbuild/buildtools#1263 Closes bazelbuild#22045. PiperOrigin-RevId: 626307672 Change-Id: Ib088e73835ea3d7076976a9de4ab4207ff491b27
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Apr 22, 2024
Fixes bazelbuild/buildtools#1263 Closes bazelbuild#22045. PiperOrigin-RevId: 626307672 Change-Id: Ib088e73835ea3d7076976a9de4ab4207ff491b27
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Apr 24, 2024
Fixes bazelbuild/buildtools#1263 Closes #22045. PiperOrigin-RevId: 626307672 Change-Id: Ib088e73835ea3d7076976a9de4ab4207ff491b27 Commit 7979dd6 --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
Such assignments don't do anything, but we shouldn't crash on them.
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Fixes bazelbuild/buildtools#1263 Closes bazelbuild#22045. PiperOrigin-RevId: 626307672 Change-Id: Ib088e73835ea3d7076976a9de4ab4207ff491b27
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such assignments don't do anything, but we shouldn't crash on them.
Context: https://bazelbuild.slack.com/archives/C014RARENH0/p1712945309438879