-
Notifications
You must be signed in to change notification settings - Fork 481
Nuxt automations #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuxt automations #4506
Conversation
| ViewFieldConditionGroup, | ||
| }, | ||
| emits: ['update-filter-type', 'add-filter', 'add-filter-group', 'filter-focussed', 'delete-filter-group', 'delete-filter', 'update-filter'], | ||
| emits: ['updateFilterType', 'addFilter', 'addFilterGroup', 'filterFocused', 'deleteFilterGroup', 'deleteFilter', 'updateFilter'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was necessary to get the service filters working in automations.
| enable-row-id | ||
| :disallow-data-synced-tables="false" | ||
| v-bind="$attrs" | ||
| v-on="$attrs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is apparently no longer necessary in Vue 3 since v-bind="$attrs" already includes handling listeners.
jonadeline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. That can be merged 🎅🏻
This PR fixes the following in Automations: