Remove dependency on read-pkg#2863
Merged
novemberborn merged 1 commit intoavajs:mainfrom Oct 17, 2021
Merged
Conversation
As discussed on Issue avajs#2863, this package was only used in one place and just to read a single property on a package.json file.
Contributor
Author
|
@live627 Please let me know if I need to change something :) |
Contributor
|
oh didn' t realize that you were expecting a reply
Your changeset looks good to me 😃
…On Thu, Oct 7, 2021 at 4:39 AM Alessandro Menezes ***@***.***> wrote:
@live627 <https://github.com/live627> Please let me know if I need to
change something :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2863 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN4I47QNCFCNKWF2ZOLUFWBFJANCNFSM5FLRDDAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
Author
|
@live627 No worries! :) The PR is now ready for review. |
novemberborn
changed the title
read-pkg package from dependenciesread-pkg
Member
|
Thanks @alessandroasm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Issue #2853, this package was only used in one place and just to read a single property on a package.json file.