feat(database-modal): add validation loading state and duplicate name check #36880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isValidating prop to TableCatalog, ValidatedInputField, and CommonParameters to show loading spinner during validation - Fix LabeledErrorBoundInput hasFeedback to display spinner while validating, not just on errors - Add duplicate database name validation to validate_parameters endpoint for real-time feedback before form submission
9 tasks
…oint - Remove early return in frontend validation hook when SSH is enabled, allowing backend validation to run for all database parameters - Add SSH tunnel field validation in ValidateDatabaseParametersCommand to validate server_address, server_port, username, and credentials - Add DatabaseSSHTunnelValidation schema for partial SSH tunnel data validation without strict authentication requirements - Add ssh_tunnel field to DatabaseValidateParametersSchema - Parse SSH tunnel errors in frontend and display under ssh_tunnel key - Collect database_name duplicate errors alongside parameter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Problem
When users fill out the database connection form, they experience two UX issues:
Solution
This PR addresses both issues:
isValidatingprop is now passed toTableCatalog,ValidatedInputField, andCommonParameterscomponents.Additionally, fixed the
LabeledErrorBoundInputcomponent where hasFeedback was only set when there was an error. Changed it, so the Ant Design FormItem displays the loading spinner during validation, not just the error icon when validation fails.ValidateDatabaseParametersCommand.validate()method to check for duplicate database names usingDatabaseDAO.validate_uniqueness()(for new databases) orDatabaseDAO.validate_update_uniqueness()(for existing databases).This provides real-time feedback as users type, preventing wasted time on form submissions that will fail.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
before.mp4
after.mp4
ADDITIONAL INFORMATION
es new feature or API