Skip to content

Conversation

@webjib
Copy link

@webjib webjib commented Nov 21, 2017

As minizip is supporting splitting zip archive, I've added a way to create archive with user-defined disk size. A disk size of 0 means we're using old open function. I've also added a size check to avoid creating parts of less than 1 KB (useful ?).

@Coeur
Copy link
Member

Coeur commented Nov 22, 2017

Nice feature.
But we can't change the signatures of createZipFileAtPath::: and open like that: we need to keep a compatibility layer, which I can easily write eventually.

@webjib
Copy link
Author

webjib commented Nov 22, 2017

You're completely right, I should have kept previous signatures. I've made a new commit to restore them.

@jhudsonWA
Copy link
Member

I'll take a look at this after the holidays. Just want to let you know you were not forgotten. Thanks for the PR.

@jhudsonWA
Copy link
Member

Working on updating the included upstream minizip library to version 2, then I'll visit this one some more.

@zhouJinYing
Copy link

zhouJinYing commented Dec 7, 2018

Nice feature.
But we can't change the signatures of createZipFileAtPath::: and open like that: we need to keep a compatibility layer, which I can easily write eventually.

你好,请问为什么不能暴露这个方法呢?是有其他的影响吗?如果要使用split的话,需要如何使用呢?直接在zip.c文件中修改ziinit.disk_size值吗?谢谢!


[edit: Google Translate]

Why can't you expose this method? Is there any other impact? If you want to use split, how do you use it? Modify the ziinit.disk_size value directly in the zip.c file?

@Coeur Coeur added the feature label Apr 9, 2019
@Patr0ck
Copy link

Patr0ck commented Jul 19, 2019

Wondering if you have any plan on merging this one...

@willson-chen willson-chen added this to the 3.0 milestone Apr 28, 2020
@willson-chen
Copy link
Member

Thanks for the PR. If you can add some testcases we will merge in v3.0

@Coeur Coeur changed the base branch from master to main July 22, 2023 19:37
@Coeur Coeur self-assigned this Sep 27, 2024
@Coeur Coeur unassigned Coeur and webjib May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants