Skip to content

Add unit tests for Schema Aggregator infrastructure classes #22814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thijsoo wants to merge 1 commit into
base: feature/schema_aggregator
Choose a base branch
from
Open

Add unit tests for Schema Aggregator infrastructure classes #22814

thijsoo wants to merge 1 commit into from

Conversation

@thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Dec 10, 2025

Context

  • We want to add unit tests.

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests for the some infrastructure classes.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo @claude
Add unit tests for Schema Aggregator infrastructure classes
ae10fa3 
This commit adds comprehensive unit tests for the Schema Aggregator infrastructure components:

- Meta_Tags_Context_Memoizer_Adapter tests for the meta_tags_context_to_array method
- Schema_Aggregator_Conditional tests for constructor and is_met method
- Schema_Aggregator_Watcher tests for constructor, register_hooks, and check_schema_aggregator_enabled methods

All tests use specific type hints (bool|int|string|null, array<string, bool|int|string>) instead of mixed types for better type safety and documentation. The test structure follows the project's established patterns with abstract base classes for shared setup code.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@thijsoo thijsoo added this to the feature/schema-aggregation milestone Dec 10, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 10, 2025
@coveralls
Copy link

coveralls commented Dec 10, 2025

Pull Request Test Coverage Report for Build 01f530a256aa8b59fadc81c382ef9c3141e62792

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 51.89%
Totals Coverage Status
Change from base Build 121d6055c956360fb867d8ed620c843ef16874b1: 0.02%
Covered Lines: 31862
Relevant Lines: 61809
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Milestone

feature/schema-aggregation

Development

Successfully merging this pull request may close these issues.

2 participants

@thijsoo @coveralls