C++23 Modernization & Page Inheritance Fix #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the C++23 modernization of ViewTouch and fixes a critical page inheritance bug introduced during refactoring.
Summary
snprintf/sprintfcalls tostd::formatChanges
1. Complete C++23 Modernization (commit 9bc5f9c)
snprintf/sprintfcalls to C++23std::formatusingformat_to_buffer()format_to_buffer,to_underlying,Result<T>2. Page Inheritance Fix (commit a1de375)
default:case inPage::Init()switch statement that forcedparent_id = 0for unhandled page typesPAGE_SYSTEM,PAGE_TEMPLATE,PAGE_CHECKS,PAGE_KITCHEN_VID,PAGE_KITCHEN_VID2,PAGE_BAR1,PAGE_BAR2parent_id3. Compiler Compatibility (commit e425f05)
__has_includedetection for<format>and<expected>headersstd::to_underlying()usingstatic_caststd::expectedtypes when availablestd::formatunavailable4. CI Workflow Updates (commits 4df8de1, 50986cb, da44a86)
std::formatin libstdc++ even with-std=c++23Testing
Requirements
std::formatsupportFiles Modified
business/,data/,hardware/,ui/