Skip to content

fix: 🐛 Android 12+ takes color as static value instead from styles #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ujas-m-simformsolutions wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 🐛 Android 12+ takes color as static value instead from styles #77

ujas-m-simformsolutions wants to merge 1 commit into from

Conversation

@ujas-m-simformsolutions
Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions commented Dec 2, 2025

Description

Adds support for different splash background colors for light mode and dark mode on Android. When a dark color is provided via the existing color_dark_android config option, the tool generates color resources in both values/ and values-night/ folders so Android automatically applies the correct theme.

Changes:

  • Create values-night/ directory automatically when dark color is provided
  • Update Android 12+ styles to reference @color/splashBgColor instead of static color values for proper dark mode support
  • Add values-night-v31/ directory support for Android 12+ dark mode styles (only when color_dark_android is provided), ensuring windowSplashScreenAnimatedIcon works properly in dark mode

Usage:

splash_master:
  color: '#FFFFFF'
  color_dark_android: '#000000'

Generated output:

<!-- android/app/src/main/res/values/colors.xml -->
<color name="splashBgColor">#FFFFFF</color>

<!-- android/app/src/main/res/values-night/colors.xml -->
<color name="splashBgColor">#000000</color>

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #20

Original prompt

This section details on the original issue you should resolve

<issue_title>Feature Request: Add Dark Mode Background Color Support for Android</issue_title>
<issue_description>## Summary

Add support for different splash background colors for light mode and dark mode on Android.
This includes generating color resources in both values/ and values-night/ folders so Android automatically applies the correct theme.

Expected Android Implementation

New Config Options
Allow users to specify:

  • dark_background_color

Output Structure (auto-generated)
Light mode

android/app/src/main/res/values/colors.xml

<resources>
    <color name="splash_background">#FFFFFF</color>
</resources>

Dark mode

android/app/src/main/res/values-night/colors.xml

<resources>
    <color name="splash_background">#000000</color>
</resources>

Splash theme should reference this color

<style name="LaunchTheme" parent="@android:style/Theme.Black.NoTitleBar">
    <item name="android:windowBackground">@color/splash_background</item>
</style>

Android will automatically switch between values/ and values-night/ based on system theme.

Acceptance Criteria

  • Add support for generating values-night/colors.xml when a dark color is provided.
  • Ensure backward compatibility if only light mode color is specified.
  • Update splash theme to reference the generated color.</issue_description>

Comments on the Issue (you are @copilot in this section)

@ujas-m-simformsolutions ujas-m-simformsolutions mentioned this pull request Dec 2, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhaval-k-simformsolutions dhaval-k-simformsolutions Awaiting requested review from dhaval-k-simformsolutions

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Add Dark Mode Background Color Support for Android

2 participants

@ujas-m-simformsolutions