AprilTag Support #151
Draft
AprilTag Support #151
+2,166
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agasser
reviewed
Dec 21, 2025
|
|
||
| namespace QuestNav.Native.AprilTag | ||
| { | ||
| public abstract class AprilTagFamily |
Contributor
There was a problem hiding this comment.
Should this implement IDisposable? I mean just adding :IDisposable and an abstract Dispose() method, assuming all AprilTagFamily implementations should be disposable.
Member
Author
There was a problem hiding this comment.
good idea haha! I'll do that
mythgarr
reviewed
Dec 24, 2025
Contributor
There was a problem hiding this comment.
What is the new passthrough resolution/ frame rate?
Member
Author
There was a problem hiding this comment.
I still need to seperate these out. I was just using that file as a proof of concept. It will probably be configurable via the web UI but for now I just commented it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.