Skip to content

Simplify some of cart logic to gradually move to single source of truth #40432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Hlavtox wants to merge 1 commit into
base: 9.1.x
Choose a base branch
from
Open

Simplify some of cart logic to gradually move to single source of truth #40432

Hlavtox wants to merge 1 commit into from
+27 −20

Conversation

@Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Dec 31, 2025 •
edited
Loading

Questions Answers
Branch? 9.1.x
Description? Simplifies some of the code and possibly gains performance, because we now avoid quite a big overhead and skip loading loads of data for nothing. Also, no need to force refresh $cart->getProducts() and load it again.
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
How to test? CI + UI
UI Tests
Fixed issue or discussion?
Related PRs
Sponsor company TRENDO s.r.o.

@Hlavtox Hlavtox added this to the 9.0.3 milestone Dec 31, 2025
@Hlavtox Hlavtox requested a review from a team as a code owner December 31, 2025 01:10
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Dec 31, 2025
@ps-jarvis ps-jarvis added Refactoring Type: Refactoring 9.0.x Branch labels Dec 31, 2025
kpodemski
kpodemski requested changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong branch.

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Dec 31, 2025
@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Dec 31, 2025
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 31, 2025

@kpodemski 9.0.x nono? It's not a BC break.

@kpodemski
Copy link
Contributor

kpodemski commented Dec 31, 2025

@kpodemski 9.0.x nono? It's not a BC break.

Let's keep things clear. It's not a fix, it's a proper improvement.

I think the only compromise we could have is to have it in 9.1.x

@Hlavtox Hlavtox force-pushed the simplify-cart-calculations branch from 049bcd6 to 3c2adf4 Compare December 31, 2025 12:13
@Hlavtox Hlavtox requested a review from a team as a code owner December 31, 2025 12:13
@Hlavtox Hlavtox changed the base branch from 9.0.x to 9.1.x December 31, 2025 12:13
@ps-jarvis ps-jarvis added 9.1.x and removed 9.0.x Branch labels Dec 31, 2025
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 31, 2025

@kpodemski Rebased. :-)

@Hlavtox Hlavtox removed the Waiting for author Status: action required, waiting for author feedback label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpodemski kpodemski kpodemski requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

9.1.x Refactoring Type: Refactoring

Projects

PR Dashboard
Status: Waiting for author

Milestone

9.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Hlavtox @kpodemski @ps-jarvis