Skip to content

[SLA] Create find_electron_temperature #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rocco8773 wants to merge 450 commits into
base: main
Choose a base branch
from
Draft

[SLA] Create find_electron_temperature #3067

rocco8773 wants to merge 450 commits into from

Conversation

@rocco8773
Copy link
Member

@rocco8773 rocco8773 commented Jul 31, 2025

...

PR #3057 needs to be merged first

rocco8773 and others added 30 commits February 1, 2021 21:08
@rocco8773
refactor default current and voltage arrays used for testing
d26dbce
@rocco8773
add test test_kwarg_min_points
5b7fd73
@rocco8773
add test test_kwarg_min_points; some PEP fixes; add docstring to `t…
296497f 
…est_kwarg_min_points`
@rocco8773
appease grumpy black
d4d0605
@rocco8773
add atol=1e-7 to isclose in test_island_finding
aeb5247
@rocco8773
add test for perfect linear and exponential
2f4f997
@rocco8773
appeas grumpy black
f2e4f43
@rocco8773 @namurphy
Apply suggestions from code review
0ac26b9 
Co-authored-by: Nick Murphy <[email protected]>
@rocco8773
phrasing
bae6520
@rocco8773 @namurphy
Apply suggestions from code review
25e14e6 
Co-authored-by: Nick Murphy <[email protected]>
@rocco8773
Merge remote-tracking branch 'fork/ad-lang-vf' into ad-lang-vf
51e2edf
@rocco8773
add import of numbers
cea466c
@rocco8773
move the "How it works" "section" to the numpydoc "Notes" section
d20998a
@rocco8773
create and test alias find_vf_ for find_floating_potential
b5eee88
@rocco8773
replace min_points == 0 functionality with min_points == np.inf
6fac0d1
@rocco8773
it's below not above
dd0cc76
@rocco8773
Merge branch 'ad-lang-vf' into sla-isat
15f4534 
# Conflicts:
#	plasmapy/analysis/swept_langmuir/__init__.py
@rocco8773
remove extra space
1b4c81d
@rocco8773
create alias find_isat_
f15b32d
@rocco8773
create test_ion_saturation_current.py and initate with test for IonSa…
11d2cde 
…turationCurrentResults
@rocco8773
create test class TestFindIonSaturationCurrent and initiate with test…
ff1aa24 
… of alias find_isat_
@rocco8773
handful of cleanup refactoring based on what was learned with find_fl…
89bb8eb 
…oating_potential
@rocco8773
fix typo
8599653
@rocco8773
Merge branch 'ad-lang-vf' into sla-isat
28ca101
@rocco8773
add plasmapy.analysis.swept_langmuir.ion_saturation_current documenta…
1900b93 
…iton files
@rocco8773
grammar fix
6498a66
@rocco8773
Merge branch 'ad-lang-vf' into sla-isat
d2b5d29
@rocco8773
Merge branch 'master_from_plasmapy' into sla-isat
66789a9 
# Conflicts:
#	docs/ad/analysis/swept_langmuir.rst
#	docs/ad/diagnostics/index.rst
#	docs/notebooks/analysis/swept_langmuir/find_floating_potential.ipynb
#	plasmapy/analysis/swept_langmuir/__init__.py
@rocco8773
remove bold syntax in hyperlink that does not render correctly on RTD
20fde53
@rocco8773
Merge branch 'main_from_pp' into sla-isat
32f905b 
# Conflicts:
#	docs/ad/analysis/swept_langmuir.rst
#	plasmapy/analysis/swept_langmuir/__init__.py
@rocco8773 rocco8773 added the plasmapy.analysis Related to the plasmapy.analysis subpackage label Jul 31, 2025
@review-notebook-app
Copy link

review-notebook-app bot commented Jul 31, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/ packaging Related to packaging or distribution python Pull requests that update Python code labels Jul 31, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 20.87912% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.39%. Comparing base (091a5f7) to head (30b86c3).

Files with missing lines Patch % Lines
...asmapy/analysis/swept_langmuir/plasma_potential.py 17.52% 80 Missing ⚠️
...py/analysis/swept_langmuir/electron_temperature.py 21.95% 64 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   94.73%   93.39%   -1.34%     
==========================================
  Files         108      110       +2     
  Lines        9869    10050     +181     
  Branches     1501     1539      +38     
==========================================
+ Hits         9349     9386      +37     
- Misses        324      468     +144     
  Partials      196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@namurphy namurphy Awaiting requested review from namurphy namurphy will be requested when the pull request is marked ready for review namurphy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

docs PlasmaPy Docs at http://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/ packaging Related to packaging or distribution plasmapy.analysis Related to the plasmapy.analysis subpackage python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rocco8773