Make @particle_input apply categorization criteria when creating a ParticleList
#2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plasmapy.particles
namurphy
added
the
bugfix
github-actions
bot
added
the
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 95.20% 95.21%
=======================================
Files 103 103
Lines 9414 9412 -2
Branches 2156 2155 -1
=======================================
- Hits 8963 8962 -1
+ Misses 274 273 -1
Partials 177 177 ☔ View full report in Codecov by Sentry. |
Member
Author
|
pre-commit.ci autofix |
…ut-list-categorization-criteria
…ut-list-categorization-criteria
Member
Author
namurphy
added a commit
to namurphy/PlasmaPy
that referenced
this pull request
May 6, 2024
…ut-list-categorization-criteria
namurphy
commented
May 6, 2024
namurphy
commented
May 6, 2024
namurphy
commented
May 8, 2024
namurphy
commented
May 8, 2024
namurphy
commented
May 8, 2024
namurphy
commented
May 8, 2024
namurphy
removed
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2048 describes a problem where particle categorization criteria were not being applied when a
ParticleListwas being supplied to a function decorated with@particle_input.The essense of the error was that a list containing any objects will be interpreted as true, even if the objects the list contains are
False.The improvements in #2648 led to a much cleaner implementation here than I had first attempted (hence the relatively long commit history).
Closes #2048.