Renaming kernel_builder to kernel #3702
Conversation
khalatepradnya
left a comment
khalatepradnya
left a comment
There was a problem hiding this comment.
The code changes look fine to me. Isn't this a breaking change to the C++ API? @efratshabtai should weigh in.
| quantum kernel code at runtime. | ||
|
|
||
| **[2]** The callable :code:`cudaq::kernel_builder` abstraction | ||
| **[2]** The callable :code:`cudaq::kernel` abstraction |
There was a problem hiding this comment.
kernel_builder is clearer IMO.
There was a problem hiding this comment.
Q: Is this change for alignment with C++? cudaq.kernel.kernel seems less clear to me.
There was a problem hiding this comment.
What's the motivation for the rename? We do want to avoid breaking changes if possible
There was a problem hiding this comment.
As per the issue filed
Recently we update the Python bindings for kernel_builder to Kernel to be more Pythonic. I actually like this a little better. This type in C++ is meant to build Quake function representations, so it is in some sense a kernel builder. But ultimately it is a callable CUDA Quantum kernel, so I think it may be better to just call it cudaq::kernel.
3 participants
Renaming cudaq::kernel_builder to cudaq::kernel.
Fixes #20.