Fix MpUnboundedXaddChunk.soPrev #394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The soPrev method implies that it's making a store with RELEASE semantics, but it was doing a plain store. This changes the method implementation to store with RELEASE, matching its naming convention. Since is also a more correct counterpart to the only loads of this field, which are always done with volatile memory semantics. It's not clear to me if this fixes a real issue on architectures with weaker memory orderings than x86.
Author
|
FYI @franz1981 |
Collaborator
|
Thanks @chrisvest for looking into this, so... In both cases there are other operations which release the prev value (along with other states) hence it could be that the prev store release could be a plain one too: this means that the method name was wrong, likely. |
Collaborator
|
And indeed I already found this but forgot to merge it, see #309 |
Author
|
Five years ago, lol. Yeah, maybe #309 need to be brought over the finish line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soPrev method implies that it's making a store with RELEASE semantics, but it was doing a plain store.
This changes the method implementation to store with RELEASE, matching its naming convention. Since is also a more correct counterpart to the only loads of this field, which are always done with volatile memory semantics.
It's not clear to me if this fixes a real issue on architectures with weaker memory orderings than x86.