[base/kvm] Add KVM enabled base container #949

nrybowski · 2023-05-23T22:47:15Z

This PR adds a new base container able to launch a specific Linux kernel within a KVM.
New grading environments should inherit from this container as it is the case for the base container.
Task leveraging such grading environments must support the SSH feature of INGInious.

TODO

Patch virtme to enable port forwarding for telnet
Add a 'KVM' label in the base container to dynamically enable KVM passthrough on the Agents
Add 'KVM' flag to Docker Agent
- Check if KVM is enabled on the Agent environment
Automate KVM launch in student container
Automate shell redirection to KVM in student container
Hardcode qemu-kvm src rpm url
Add documentation

TODO in further PRs

Use serial port to spawn a shell (see virtme) in the VM rather than using telnet and port forwarding
Log the commands typed in the telnet shell as here

https://github.com/UCL-INGI/INGInious/blob/a9962cad2a18caf87a73f10c627fc98f561f0e6c/base-containers/base/inginious_container_api/utils.py#L79

Such logs could be used in further grading scripts.

[Frontend/Submissions] fix - change class for file code icon

add - submission date to feedback

…ous#821) * using tabs to simplify display * fix tiny bug if "activate lti" is checked and then unchecked, it displays "access control type" independently of selected access control * Hide lti tab if lti option is not activated in general tab

This keeps the file metadata (permissions, dates, ...). Fix INGInious#390

…s#839) Fix INGInious#798

…nious#849) Warning: this doesn't ensure retrocompatibilty with previous weighing system.

…NGInious#852)

…nser (INGInious#851)

…Dispenser (INGInious#854)

The new router does not perform correctly when using regex groups. Moreover, it is now required to explicitely tell it the converter can match the forward / using ``part_isolating``.

Fix INGInious#743

[backend] do not erase previous state in case of errors

… by default (INGInious#863)

Currently translated at 92.3% (680 of 736 strings) Translation: INGInious/Frontend Translate-URL: https://weblate.info.ucl.ac.be/projects/inginious/frontend/fr/

Translations update from Weblate

Fix INGInious#887

[agent/docker] replace SSH opt-in by env types

Translations update from Weblate

Fixes INGInious#697. This is a first mitigation and in all case useful, as the limit is set on the total command sent to the MongoDB server, which cannot be computed before.

[frontend/submission_manager] catch DocumentTooLarge exception

Updated setup requirements to Flask 2.0+ that introduces the new function. Fix INGInious#942

See INGInious/INGInious#949.

base-containers/kvm/Dockerfile

nrybowski · 2023-05-24T11:58:03Z

This PR should solve #939.

nrybowski · 2023-05-26T13:12:16Z

Some slowness is observed during the execution of a simple mininet command such as mn --switch lxbr --topo tree,depth=2,fanout=8 --test pingall at the startup of the fifth switch.
The VM has two cores and 256Mo of RAM but none of those ressources are used at their maximum.
Further investigation is required but do not prevent the integration of this feature which is anyway still experimental.

anthonygego

This is very a first pass. I'd like to see those issues addressed first because I'm wondering if there is a possibility to make this fully modular and if it would be relevant.

Indeed, the added lines seem very tied to the additional container architecture and make code harder to understand. I would know if it's possible to put these additional piece of codes in a kind of hook folder provided in the container image.

anthonygego · 2023-07-07T13:19:06Z

inginious/agent/docker_agent/_docker_interface.py

            runtime=runtime,
-            ulimits=[nofile_limit]
+            ulimits=[nofile_limit],
+            devices=['/dev/kvm'] if kvm and image_requires_kvm else []


I fear that unwanted behaviours can happen silently here. If the container image requires kvm and the agent does not support/enable it, no notification will be given. There seems to be no way for the user to know if the agent supports kvm, and, moreover, nothing prevents the job to be assigned to an inappropriate agent.

I'm however more likely to deploy an agent that do support kvm into a cluster of other agents that don't.

For me it would probably be more relevant to implement this as the ssh or nvidia filters : announce another agent type that will allow container images tagged with org.inginious.kvm to be listed as available environment, so that we can ensure appropriate routing and ensure the user selected the right environment.

Implementation of nvidia is here f842bee

However, I realize that implementing a kvm filter, as it may be compatible with other agent type, would require to duplicate all those one to have a kvm-enabled flavour.

Maybe it would be useful to rethink the way this is done and add some kind of feature flags in addition to the agent type, so that we can handle docker or nvidia with ssh or kvm as supported features or not.

After discussion with @anthonygego, this will be implemented as existing filters (ssh, nvidia, ..).
The features flags common to all the Agents will be grouped in a new data-class.

Front-end side, the grading environment should not include the feature flags in the dropdown and those will be added as check boxes.

base-containers/kvm/Dockerfile

anthonygego · 2023-07-07T13:27:14Z

base-containers/base/bin/_run_student_intern

 # Check the runtimes
 runtime = sys.argv[1]
 parent_runtime = sys.argv[2]
+kvm_enabled = sys.argv[3] == "True"


I'd document the args at both sides, here and at the call side in _docker_interface.py (to avoid implementing a useless argumentparser that would be self documenting)

The arguments managment will be replaced by an argparser.

nrybowski · 2025-01-06T09:40:19Z

v1.32 of virtme now supports SSH. We should bump the version and replace the telnet hack with this new feature.

anthonygego · 2025-03-25T16:19:28Z

Can you rebase your branch against main (you'll probably have to cherry-pick) ? I think there should be no or very few conflicts to solve.

anaHue and others added 30 commits July 4, 2022 11:17

fix - change class for file code icon

257272b

Merge pull request INGInious#829 from anaHue/fix_missing_icon

d217a51

[Frontend/Submissions] fix - change class for file code icon

add - submission date to feedback

8387d00

use strftime instead of replacing microseconds

92edb30

corrected the display for submission date

752bc46

Merge pull request INGInious#831 from anaHue/fix_issue_278

eccc423

add - submission date to feedback

[frontend/course_admin] fix bad student count (INGInious#836)

d5726df

[filesystems/local] use copy2 instead of copy (INGInious#840)

7de1fb1

This keeps the file metadata (permissions, dates, ...). Fix INGInious#390

[frontend/course_admin] move tags page to settings page (INGInious#841)

b55107c

[course_admin/edit_tabs] add network interface hint tooltip (INGIniou…

c1f47ac

…s#839) Fix INGInious#798

[frontend] Moving the concept of weight into the Task Dispenser (INGI…

fc5bde4

…nious#849) Warning: this doesn't ensure retrocompatibilty with previous weighing system.

[task_dispenser/combinatory_test] now return a proper dispenser data (I…

7a4a27d

…NGInious#852)

[frontend] Moving the number of stored submission into the Task Dispe…

7c05707

…nser (INGInious#851)

[ci] temporarily mitigate issue with markupsafe

18d6025

[frontend] Moving the concept of evaluation submission into the Task …

78e05cf

…Dispenser (INGInious#854)

[doc] fix INGInious#856 : typo in hidden-until docs

4b64864

[frontend] Categories managed by the Task Dispenser (INGInious#855)

ae95c5e

[routes] adapt CookielessConverter to new werkzeug router

83a76a0

The new router does not perform correctly when using regex groups. Moreover, it is now required to explicitely tell it the converter can match the forward / using ``part_isolating``.

[backend] do not erase previous state in case of errors

a1dc28f

Fix INGInious#743

Merge pull request INGInious#857 from UCL-INGI/keep_state_on_errors

cad231e

[backend] do not erase previous state in case of errors

[installer] Add default configuration flag (INGInious#860)

0c52359

[audiences] replace import/export format by human-readable CSV

300e7ce

[frontend/parsable_text] fix hidden-until behaviour when time is passed

d495824

[frontend/tasks] add ssh client option to use password authentication…

e7ffd0d

… by default (INGInious#863)

Update issue templates

64d71e3

[frontend/i18n] fix variable name in portuguese string

0a882b1

Translated using Weblate (French)

706ec66

Currently translated at 92.3% (680 of 736 strings) Translation: INGInious/Frontend Translate-URL: https://weblate.info.ucl.ac.be/projects/inginious/frontend/fr/

[frontend/course_admin] add additional course fields (INGInious#825)

b8523f7

Merge pull request INGInious#859 from INGIbot/weblate-inginious-frontend

3599289

Translations update from Weblate

anthonygego and others added 8 commits April 20, 2023 11:03

[agent/docker] replace SSH opt-in by env types

6fcd7c5

Fix INGInious#887

Merge pull request INGInious#940 from UCL-INGI/fix_887

b3f66e3

[agent/docker] replace SSH opt-in by env types

Merge pull request INGInious#935 from INGIbot/weblate-inginious-frontend

789df86

Translations update from Weblate

[frontend/submission_manager] catch DocumentTooLarge exception

09629d1

Fixes INGInious#697. This is a first mitigation and in all case useful, as the limit is set on the total command sent to the MongoDB server, which cannot be computed before.

Merge pull request INGInious#941 from UCL-INGI/fix_697

f348216

[frontend/submission_manager] catch DocumentTooLarge exception

[frontend/flask] fix session_cookie_name deprecation

509210c

Updated setup requirements to Flask 2.0+ that introduces the new function. Fix INGInious#942

[setup] temporarily restrict to requests<2.2.29

7fc0983

[base/kvm] Add KVM enabled base container

88d9b49

nrybowski added a commit to nrybowski/INGInious-containers that referenced this pull request May 23, 2023

Use new KVM base env

38c73bf

See INGInious/INGInious#949.

[base/kvm] Fixes + make codacy happy

16303b4

anthonygego reviewed May 24, 2023

View reviewed changes

base-containers/kvm/Dockerfile Outdated Show resolved Hide resolved

nrybowski linked an issue May 24, 2023 that may be closed by this pull request

Runtime environments allowing to run as root could provide more capabilities to the containers #939

Open

nrybowski added 5 commits May 24, 2023 15:11

Enable KVM passthrough agent-side

f8a83de

[base/kvm] Fix virtme patch + add missing telnet config

ecbcfd2

[base/kvm] Fix virtme-run path

a954d86

[base/kvm] Automated KVM launch on student container launch

99a07f6

[base/kvm] Launch telnet to KVM at SSH connection

e7c4628

nrybowski marked this pull request as ready for review May 25, 2023 23:24

[base/kvm] Hardcode qemu-kvm src rpm URL

703ba30

anthonygego reviewed Jul 7, 2023

View reviewed changes

[env/kvm] Launch task script, if any, on student SSH login

d726555

nrybowski force-pushed the master branch 2 times, most recently from e53b0e2 to 9a6d192 Compare December 21, 2024 13:51

anthonygego changed the base branch from master to main March 25, 2025 16:18

anthonygego marked this pull request as draft April 11, 2025 15:25

nrybowski added the Feedback needed Project maintainers wait for feedback from OP label Jun 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[base/kvm] Add KVM enabled base container #949

[base/kvm] Add KVM enabled base container #949

Uh oh!

nrybowski commented May 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

nrybowski commented May 24, 2023

Uh oh!

nrybowski commented May 26, 2023

Uh oh!

anthonygego left a comment

Uh oh!

anthonygego Jul 7, 2023

Uh oh!

nrybowski Aug 31, 2023

Uh oh!

Uh oh!

anthonygego Jul 7, 2023

Uh oh!

nrybowski Aug 31, 2023

Uh oh!

nrybowski commented Jan 6, 2025

Uh oh!

anthonygego commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

[base/kvm] Add KVM enabled base container #949

Are you sure you want to change the base?

[base/kvm] Add KVM enabled base container #949

Uh oh!

Conversation

nrybowski commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

TODO in further PRs

Uh oh!

Uh oh!

nrybowski commented May 24, 2023

Uh oh!

nrybowski commented May 26, 2023

Uh oh!

anthonygego left a comment

Choose a reason for hiding this comment

Uh oh!

anthonygego Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

nrybowski Aug 31, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anthonygego Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

nrybowski Aug 31, 2023

Choose a reason for hiding this comment

Uh oh!

nrybowski commented Jan 6, 2025

Uh oh!

anthonygego commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

nrybowski commented May 23, 2023 •

edited

Loading