🔧 config(unxt): workspace extra #534
Conversation
github-actions
bot
added
the
🔧 Add / update configuration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 96.76% 96.76%
=======================================
Files 44 44
Lines 2068 2068
Branches 69 69
=======================================
Hits 2001 2001
Misses 51 51
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
github-actions
bot
added
the
👷 Add / update CI build system
There was a problem hiding this comment.
Pull request overview
This PR restructures the workspace package dependencies by introducing a new workspace optional extra for the main unxt package. This allows users to optionally install the workspace packages (unxt-api and unxt-hypothesis) when needed, rather than having them as development dependencies.
Key changes:
- Introduces a
workspaceoptional extra containingunxt-apiandunxt-hypothesis, included in theallextra - Removes the
workspacedependency group and movesunxt-hypothesisout of development dependency groups (dev,test,test-all) - Adds
dependency-groupswith test dependencies to both workspace packages (unxt-apiandunxt-hypothesis) - Updates nox sessions to use
uv_extras=["workspace"]instead ofuv_groups=["workspace"] - Updates GitHub Actions workflow labels from
workspace: <package>to🧩 <package>format
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds workspace optional extra, removes workspace dependency group and unxt-hypothesis from test dependency groups |
| uv.lock | Updates lockfile to reflect dependency reorganization, moving workspace packages from dev dependencies to optional extras |
| packages/unxt-api/pyproject.toml | Adds test dependency group for independent testing of the workspace package |
| packages/unxt-hypothesis/pyproject.toml | Adds test dependency group for independent testing of the workspace package |
| noxfile.py | Updates pytest and docs sessions to use uv_extras=["workspace"] instead of uv_groups=["workspace"] |
| .github/workflows/ci.yml | Updates workspace package labels from text format to emoji format (🧩) |
| .github/labels.yml | Defines new labels for workspace packages with emoji prefix |
| backend-astropy = ["astropy>=6.0"] | ||
| interop-gala = ["gala>=1.8"] | ||
| interop-mpl = ["matplotlib>=3.8"] | ||
| workspace = ["unxt-api", "unxt-hypothesis"] |
There was a problem hiding this comment.
The workspace extra includes unxt-api, but unxt-api is already a required dependency in the main dependencies list (line 35). Including it in the workspace extra creates redundancy since unxt-api will always be installed regardless of whether the workspace extra is used. Consider removing unxt-api from this extra and keeping only unxt-hypothesis, or if the intent is to have unxt-api as optional, move it from the core dependencies to only this extra.
| workspace = ["unxt-api", "unxt-hypothesis"] | |
| workspace = ["unxt-hypothesis"] |
|
|
||
| [dependency-groups] | ||
| test = [ | ||
| "hypothesis[numpy]>=6.138.14", |
There was a problem hiding this comment.
The test dependency group includes hypothesis[numpy]>=6.138.14 which duplicates the same dependency already listed in unxt-hypothesis's core dependencies (line 21 of packages/unxt-hypothesis/pyproject.toml). Since this package already requires hypothesis as a runtime dependency, including it again in the test group is redundant and could lead to version conflicts or confusion about which version specification takes precedence.
| "hypothesis[numpy]>=6.138.14", |
Co-authored-by: Nathaniel Starkman <[email protected]>
1 participant
No description provided.