Fix merge conflicts for: Let you choose the Culture used for TypeConversion in the processor #79 #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion in the processor Biarity#79
Collaborator
|
@yannickdp Please add/update unit test cases for this. |
Collaborator
|
@yannickdp Thanks for your contribution. There was a major fork merge lately. Can you please rebase your branch and change the target to releases/2.5.0 ? And please add/update unit test cases for this change as @a-patel suggested. |
hasanmanzak
requested changes
Jan 12, 2022
Collaborator
There was a problem hiding this comment.
I fixed the conflicts. Still needs unit tests, though.
@a-patel @ITDancer13 @Biarity ,
What do you think about this change?
Collaborator
LGTM, tests are available in https://github.com/Biarity/Sieve/pull/187/files @yannickdp, can you take a look at the tests and move them to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @a-patel,
I've made a new pull request in which I've redone the changes of @jonatanantoine (see #79).
Can you please approve this and create a release?
Thank you very much.
Yannick