A test for pull request #718#1
Merged
zweibieren merged 9 commits intozweibieren:masterfrom Jan 25, 2018
Merged
Conversation
If optimized alignment is shorter than the initial one, trailing zeros will remain. As zero is a valid residue index, this may lead to broken logic when the alignment is processed further down the line, e.g., in subunit clustering for pseudo-symmetry.
Testing if alignments contain duplicate indices for CE and FatCatRigid.
Trimming zeroes in optimised alignment
Fixing hmmer scan web service and adding test for it
Owner
|
The test fails. It says that the uncompressed stream has an additional newline. However, the code contains the "original text" as a constant, without a newline. But decompressing the test file with the unix "uncompress" command shows that the original test file did have a newline. A simple correction is to add the newline to the constant in the test program. |
Author
|
You are totally right, unix uncompress behaves in the same way and outputs a new line too. Perhaps the compress program added a new line? I'm not sure what happened exactly. My bad. Could you add that new line and commit to your PR. After that we can merge. Thank you! |
Owner
|
I'm also adding a longer test case. half-an-hour or less
On Thursday, January 25, 2018, 2:59:25 PM EST, Jose Manuel Duarte <[email protected]> wrote:
You are totally right, unix uncompress behaves in the same way and outputs a new line too. Perhaps the compress program added a new line? I'm not sure what happened exactly. My bad.
Could you add that new line and commit to your PR. After that we can merge. Thank you!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Owner
|
I've added a pull request with the test fix and a bigger test. compress depends on file size
On Thursday, January 25, 2018, 2:59:25 PM EST, Jose Manuel Duarte <[email protected]> wrote:
You are totally right, unix uncompress behaves in the same way and outputs a new line too. Perhaps the compress program added a new line? I'm not sure what happened exactly. My bad.
Could you add that new line and commit to your PR. After that we can merge. Thank you!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test doesn't pass. An extra new line character appears in the uncompressed text.