Fix all current mypy ignores#1827
Draft
puddly wants to merge 53 commits into
Draft
Conversation
Clean up ZDO types
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1827 +/- ##
==========================================
- Coverage 99.54% 99.50% -0.04%
==========================================
Files 64 64
Lines 13213 13238 +25
==========================================
+ Hits 13153 13173 +20
- Misses 60 65 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a (massive) typing-only PR that fixes all of the mypy ignores we currently use in zigpy. Untyped definitions are the only last hurdle and those should be fixable in a future PR. There are a few noisy checks like
unreachableandredundant-exprthat likely can be inlined at some point, allowing us to get rid of the mypy ignore config in its entirety.All changes are compatible with both ZHA and quirks. There is a lot of internal type reshuffling, some hierarchy cleanup, and a few strange uses of
if TYPE_CHECKINGbut overall the fixes are straightforward.Mypy by default isn't very strict so I've also enabled more flags and repopulated the ignore lists again, bringing us back to square one.