Fix configure_reporting_multiple not returning responses#1764
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1764 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 63 63
Lines 12676 12680 +4
=======================================
+ Hits 12615 12619 +4
Misses 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes Cluster.configure_reporting_multiple() so it returns per-attribute response records instead of always returning an empty list, aligning the method’s behavior with callers’ expectations and the PR description.
Changes:
- Append each manufacturer-group’s
reporting_resultsinto the finalresultslist returned byconfigure_reporting_multiple(). - Update existing tests to capture and assert the returned result list length/statuses for several response scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
zigpy/zcl/__init__.py |
Extends the returned results with the response records computed per manufacturer code group. |
tests/test_zcl.py |
Updates tests to assert configure_reporting_multiple() returns a result per configured attribute (in covered scenarios). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The method is now pretty similar to I think we're still missing test coverage for combined manufacturer code calls both for |
* Fix `configure_reporting_multiple` not returning reporting responses * Check returned list in tests * Fix return for partial failures missing successful configs * Fix return for partial failure with `attrid` set causing global success * Align with `write_attributes` for order and only include attributes we requested * Align with `write_attributes` to use generator * Update tests
Proposed change
This PR fixes numerous issues in the
configure_reporting_multiplemethod:reporting_resultsare now correctly added to theresultslist that's returned at the end.write_attributes.Additional information
Seen in:
Related: