Cluster data type cleanup#1759
Draft
puddly wants to merge 9 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1759 +/- ##
==========================================
+ Coverage 99.51% 99.53% +0.01%
==========================================
Files 63 63
Lines 12676 13205 +529
==========================================
+ Hits 12615 13144 +529
Misses 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
commented
Feb 4, 2026
puddly
commented
Feb 4, 2026
puddly
commented
Feb 4, 2026
puddly
commented
Feb 4, 2026
puddly
commented
Feb 4, 2026
TheJulianJES
reviewed
Feb 4, 2026
TheJulianJES
reviewed
Feb 4, 2026
TheJulianJES
reviewed
Feb 4, 2026
Comment on lines
571
to
575
| class AttributeDefs(BaseAttributeDefs): | ||
| fan_mode: Final = ZCLAttributeDef(id=0x0000, type=FanMode, access="") | ||
| fan_mode_sequence: Final = ZCLAttributeDef( | ||
| id=0x0001, type=FanModeSequence, access="" | ||
| ) |
Contributor
There was a problem hiding this comment.
Access and mandatory can be added to the Fan attributes:
class AttributeDefs(BaseAttributeDefs):
fan_mode: Final = ZCLAttributeDef(
id=0x0000, type=FanMode, access="rw", mandatory=True
)
fan_mode_sequence: Final = ZCLAttributeDef(
id=0x0001, type=FanModeSequence, access="rw", mandatory=True
)
TheJulianJES
reviewed
Feb 4, 2026
| id=0x000F, type=Options, access="rw", mandatory=True | ||
| ) | ||
| # Defined Primaries Information | ||
| num_primaries: Final = ZCLAttributeDef(id=0x0010, type=t.uint8_t, access="r") |
Contributor
There was a problem hiding this comment.
num_primaries is apparently mandatory=True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a second pass through our cluster definitions and implemented every enum and bitmap properly. This migrates zigpy itself away from using
t.enum8ort.bitmap8internally, in preparation for slowly deprecating the generic types.