Fixed false positive in new stringLiteralWrite checker

danmar · danmar · commit e837bad01d50 · 2015-05-03T12:34:27.000+02:00
diff --git a/lib/checkstring.cpp b/lib/checkstring.cpp
@@ -35,7 +35,7 @@ namespace {
 void CheckString::stringLiteralWrite()
 {
     for (const Token* tok = _tokenizer->tokens(); tok; tok = tok->next()) {
-        if (!tok->variable())
+        if (!tok->variable() || !tok->variable()->isPointer())
             continue;
         const Token *str = tok->getValueTokenMinStrSize();
         if (!str)
diff --git a/test/teststring.cpp b/test/teststring.cpp
@@ -111,8 +111,8 @@ class TestString : public TestFixture {
         ASSERT_EQUALS("[test.cpp:3]: (error) Modifying string literal directly or indirectly is undefined behaviour\n", errout.str());
 
         check("void f() {\n"
-              "  char *abc = \"abc\";\n"
-              "  if (*abc == 'a'){}\n"
+              "  QString abc = \"abc\";\n"
+              "  abc[0] = 'a';\n"
               "}");
         ASSERT_EQUALS("", errout.str());
     }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ namespace {`
`35`	`35`	`void CheckString::stringLiteralWrite()`
`36`	`36`	`{`
`37`	`37`	`for (const Token* tok = _tokenizer->tokens(); tok; tok = tok->next()) {`
`38`		`- if (!tok->variable())`
	`38`	`+ if (!tok->variable() \|\| !tok->variable()->isPointer())`
`39`	`39`	`continue;`
`40`	`40`	`const Token *str = tok->getValueTokenMinStrSize();`
`41`	`41`	`if (!str)`