Refactor Stream<Optional<?>> example

Grzegorz Piwowarek · Grzegorz Piwowarek · commit 03ebc0255644 · 2016-09-24T11:33:47.000+02:00
diff --git a/core-java-9/src/test/java/com/baeldung/java9/Java9OptionalsStreamTest.java b/core-java-9/src/test/java/com/baeldung/java9/Java9OptionalsStreamTest.java
@@ -13,48 +13,43 @@
 
 public class Java9OptionalsStreamTest {
 
-    private List<Optional<String>> listOfOptionals;
+    private static List<Optional<String>> listOfOptionals = Arrays.asList(Optional.empty(), Optional.of("foo"), Optional.empty(), Optional.of("bar"));
 
-    @Before
-    public void populateStream() {
-        listOfOptionals = Arrays.asList(Optional.empty(), Optional.of("foo"), Optional.empty(), Optional.of("bar"));
-    }
-    
     @Test
     public void filterOutPresentOptionalsWithFilter() {
         assertEquals(4, listOfOptionals.size());
-        //@format:off
+
         List<String> filteredList = listOfOptionals.stream()
-                .filter(Optional::isPresent)
-                .map(Optional::get)
-                .collect(Collectors.toList());
-        //@format:on
+          .filter(Optional::isPresent)
+          .map(Optional::get)
+          .collect(Collectors.toList());
+
         assertEquals(2, filteredList.size());
         assertEquals("foo", filteredList.get(0));
         assertEquals("bar", filteredList.get(1));
     }
-    
+
     @Test
     public void filterOutPresentOptionalsWithFlatMap() {
         assertEquals(4, listOfOptionals.size());
-        //@format:off
+
         List<String> filteredList = listOfOptionals.stream()
-                .flatMap(o -> o.isPresent() ? Stream.of(o.get()) : Stream.empty())
-                .collect(Collectors.toList());
-        //@format:on
+          .flatMap(o -> o.isPresent() ? Stream.of(o.get()) : Stream.empty())
+          .collect(Collectors.toList());
         assertEquals(2, filteredList.size());
+
         assertEquals("foo", filteredList.get(0));
         assertEquals("bar", filteredList.get(1));
     }
 
     @Test
     public void filterOutPresentOptionalsWithJava9() {
         assertEquals(4, listOfOptionals.size());
-        //@format:off
+
         List<String> filteredList = listOfOptionals.stream()
-                .flatMap(Optional::stream)
-                .collect(Collectors.toList());
-        //@format:on
+          .flatMap(Optional::stream)
+          .collect(Collectors.toList());
+
         assertEquals(2, filteredList.size());
         assertEquals("foo", filteredList.get(0));
         assertEquals("bar", filteredList.get(1));
