Don't instantiate unnecessary exception for valid JSON

rumdidumdum · rumdidumdum · commit 804b1bbb8727 · 2017-08-29T09:19:40.000+02:00
diff --git a/lib/src/main/java/com/auth0/jwt/impl/JWTParser.java b/lib/src/main/java/com/auth0/jwt/impl/JWTParser.java
@@ -49,14 +49,17 @@ static ObjectMapper getDefaultObjectMapper() {
 
     @SuppressWarnings("WeakerAccess")
     <T> T convertFromJSON(String json, Class<T> tClazz) throws JWTDecodeException {
-        JWTDecodeException exception = new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));
         if (json == null) {
-            throw exception;
+            throw exceptionForInvalidJson(null);
         }
         try {
             return mapper.readValue(json, tClazz);
         } catch (IOException e) {
-            throw exception;
+            throw exceptionForInvalidJson(json);
         }
     }
+
+    private JWTDecodeException exceptionForInvalidJson(String json) {
+        return new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -49,14 +49,17 @@ static ObjectMapper getDefaultObjectMapper() {`
`49`	`49`
`50`	`50`	`@SuppressWarnings("WeakerAccess")`
`51`	`51`	`<T> T convertFromJSON(String json, Class<T> tClazz) throws JWTDecodeException {`
`52`		`- JWTDecodeException exception = new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));`
`53`	`52`	`if (json == null) {`
`54`		`- throw exception;`
	`53`	`+ throw exceptionForInvalidJson(null);`
`55`	`54`	`}`
`56`	`55`	`try {`
`57`	`56`	`return mapper.readValue(json, tClazz);`
`58`	`57`	`} catch (IOException e) {`
`59`		`- throw exception;`
	`58`	`+ throw exceptionForInvalidJson(json);`
`60`	`59`	`}`
`61`	`60`	`}`
	`61`	`+`
	`62`	`+ private JWTDecodeException exceptionForInvalidJson(String json) {`
	`63`	`+ return new JWTDecodeException(String.format("The string '%s' doesn't have a valid JSON format.", json));`
	`64`	`+ }`
`62`	`65`	`}`