ActionContext.loginAndRedirect does not trigger redirect to happen actframework#648

greenlaw110 · greenlaw110 · commit d28bc71477b1 · 2018-04-24T16:02:09.000+10:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # ActFramework Change Log
 
 **1.8.8**
+* `ActionContext.loginAndRedirect` does not trigger redirect to happen #648
 * Add act version info in the error page in dev mode #639
 * JSON Writer shall use default date/time pattern setting when i18n is not enabled - related to #645
 * Enum resolving - support non-exact keyword based matching #643
diff --git a/src/main/java/act/app/ActionContext.java b/src/main/java/act/app/ActionContext.java
@@ -984,7 +984,7 @@ public void loginAndRedirectBack(String username, String defaultLandingUrl) {
      */
     public void loginAndRedirect(String username, String url) {
         login(username);
-        redirect(url);
+        throw redirect(url);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -984,7 +984,7 @@ public void loginAndRedirectBack(String username, String defaultLandingUrl) {`
`984`	`984`	`*/`
`985`	`985`	`public void loginAndRedirect(String username, String url) {`
`986`	`986`	`login(username);`
`987`		`- redirect(url);`
	`987`	`+ throw redirect(url);`
`988`	`988`	`}`
`989`	`989`
`990`	`990`	`/**`