Add RunApp.start(packageName) API; minor code update in ParamTree; fix issue in CollectionLoader when NumberFormatException encountered;

greenlaw110 · greenlaw110 · commit 0922b644d953 · 2016-12-04T07:44:02.000+08:00
diff --git a/src/main/java/act/boot/app/RunApp.java b/src/main/java/act/boot/app/RunApp.java
@@ -27,6 +27,10 @@ public static void start(Class<?> anyController) throws Exception {
         start(null, null, anyController);
     }
 
+    public static void start(String packageName) throws Exception {
+        start(null, null, packageName);
+    }
+
     public static void start(String appName, String appVersion, Class<?> anyController) throws Exception {
         String pkg = anyController.getPackage().getName();
         start(appName, appVersion, pkg);
diff --git a/src/main/java/act/inject/param/CollectionLoader.java b/src/main/java/act/inject/param/CollectionLoader.java
@@ -89,7 +89,7 @@ public Object load(Object bean, ActContext<?> context, boolean noDefaultValue) {
                 try {
                     id = Integer.parseInt(s);
                 } catch (NumberFormatException e) {
-                    throw new BadRequest("cannot parse param: list index[%s] is not a number: %s", s);
+                    throw new BadRequest("cannot parse param: list index is not a number: %s", s);
                 }
                 ParamTreeNode child = node.child(s);
                 if (child.isLeaf()) {
diff --git a/src/main/java/act/inject/param/ParamTree.java b/src/main/java/act/inject/param/ParamTree.java
@@ -1,23 +1,27 @@
 package act.inject.param;
 
 import act.util.ActContext;
+import org.osgl.logging.LogManager;
+import org.osgl.logging.Logger;
 import org.rythmengine.utils.S;
 
 import java.util.*;
 
 class ParamTree {
 
+    private static final Logger LOGGER = LogManager.get(ParamTree.class);
+
     private Map<ParamKey, ParamTreeNode> allNodes = new HashMap<ParamKey, ParamTreeNode>();
 
     void build(ActContext context) {
         Set<String> paramKeys = context.paramKeys();
         for (String key : paramKeys) {
             String[] vals = context.paramVals(key);
-            buildNode(key, vals, context);
+            buildNode(key, vals);
         }
     }
 
-    private void buildNode(String rawKey, String[] vals, ActContext<?> context) {
+    private void buildNode(String rawKey, String[] vals) {
         ParamKey key = ParamKey.of(parseRawParamKey(rawKey));
         ParamTreeNode node;
         int len = vals.length;
@@ -106,6 +110,8 @@ private static void addTokenToList(List<String> list, StringBuilder token) {
         String s = token.toString();
         if (S.notEmpty(s)) {
             list.add(s);
+        } else {
+            LOGGER.warn("empty index encountered");
         }
         token.delete(0, s.length() + 1);
     }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public Object load(Object bean, ActContext<?> context, boolean noDefaultValue) {`
`89`	`89`	`try {`
`90`	`90`	`id = Integer.parseInt(s);`
`91`	`91`	`} catch (NumberFormatException e) {`
`92`		`- throw new BadRequest("cannot parse param: list index[%s] is not a number: %s", s);`
	`92`	`+ throw new BadRequest("cannot parse param: list index is not a number: %s", s);`
`93`	`93`	`}`
`94`	`94`	`ParamTreeNode child = node.child(s);`
`95`	`95`	`if (child.isLeaf()) {`