Merge pull request kubernetes-client#607 from brendandburns/exec

k8s-ci-robot · web-flow · commit a03550ddd964 · 2019-07-08T07:30:35.000-07:00
Improve the exec example.
diff --git a/.travis.yml b/.travis.yml
@@ -1,4 +1,4 @@
 language: java
-script: mvn -q test -B
+script: mvn -q test -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 after_success:
-  - mvn deploy --settings settings.xml -DskipTests=true -B
+  - mvn deploy --settings settings.xml -DskipTests=true -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
diff --git a/examples/pom.xml b/examples/pom.xml
@@ -36,6 +36,11 @@
 			<artifactId>guava</artifactId>
 			<version>25.1-jre</version>
 		</dependency>
+		<dependency>
+			<groupId>commons-cli</groupId>
+			<artifactId>commons-cli</artifactId>
+			<version>1.4</version>
+		</dependency>
 		<!-- test dependencies -->
 		<dependency>
 			<groupId>junit</groupId>
diff --git a/examples/src/main/java/io/kubernetes/client/examples/ExecExample.java b/examples/src/main/java/io/kubernetes/client/examples/ExecExample.java
@@ -21,6 +21,12 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.CommandLineParser;
+import org.apache.commons.cli.DefaultParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.ParseException;
 
 /**
  * A simple example of how to use the Java API
@@ -31,15 +37,21 @@
  * <p>From inside $REPO_DIR/examples
  */
 public class ExecExample {
-  public static void main(String[] args) throws IOException, ApiException, InterruptedException {
-    String podName = "nginx-4217019353-k5sn9";
-    String namespace = "default";
+  public static void main(String[] args)
+      throws IOException, ApiException, InterruptedException, ParseException {
+    final Options options = new Options();
+    options.addOption(new Option("p", "pod", true, "The name of the pod"));
+    options.addOption(new Option("n", "namespace", true, "The namespace of the pod"));
+
+    CommandLineParser parser = new DefaultParser();
+    CommandLine cmd = parser.parse(options, args);
+
+    String podName = cmd.getOptionValue("p", "nginx-dbddb74b8-s4cx5");
+    String namespace = cmd.getOptionValue("n", "default");
     List<String> commands = new ArrayList<>();
 
-    int len = args.length;
-    if (len >= 1) podName = args[0];
-    if (len >= 2) namespace = args[1];
-    for (int i = 2; i < len; i++) {
+    args = cmd.getArgs();
+    for (int i = 0; i < args.length; i++) {
       commands.add(args[i]);
     }
 
