Return non-const object to enable move compiler optimization (cppcheck-opensource#966)

alexandear · danmar · commit 2bee664ec9ed · 2017-10-03T18:24:18.000+02:00
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
@@ -944,7 +944,7 @@ int CppCheckExecutor::check_internal(CppCheck& cppcheck, int /*argc*/, const cha
 
 #ifdef _WIN32
 // fix trac ticket #439 'Cppcheck reports wrong filename for filenames containing 8-bit ASCII'
-static inline const std::string ansiToOEM(const std::string &msg, bool doConvert)
+static inline std::string ansiToOEM(const std::string &msg, bool doConvert)
 {
     if (doConvert) {
         const unsigned msglength = msg.length();
diff --git a/lib/path.cpp b/lib/path.cpp
@@ -126,7 +126,7 @@ std::string Path::getFilenameExtensionInLowerCase(const std::string &path)
     return extension;
 }
 
-const std::string Path::getCurrentPath()
+std::string Path::getCurrentPath()
 {
     char currentPath[4096];
 
diff --git a/lib/path.h b/lib/path.h
@@ -101,7 +101,7 @@ class CPPCHECKLIB Path {
      * @brief Returns the absolute path of current working directory
      * @return absolute path of current working directory
      */
-    static const std::string getCurrentPath();
+    static std::string getCurrentPath();
 
     /**
      * @brief Check if given path is absolute

Original file line number	Diff line number	Diff line change
`@@ -944,7 +944,7 @@ int CppCheckExecutor::check_internal(CppCheck& cppcheck, int /argc/, const cha`
`944`	`944`
`945`	`945`	`#ifdef _WIN32`
`946`	`946`	`// fix trac ticket #439 'Cppcheck reports wrong filename for filenames containing 8-bit ASCII'`
`947`		`-static inline const std::string ansiToOEM(const std::string &msg, bool doConvert)`
	`947`	`+static inline std::string ansiToOEM(const std::string &msg, bool doConvert)`
`948`	`948`	`{`
`949`	`949`	`if (doConvert) {`
`950`	`950`	`const unsigned msglength = msg.length();`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ std::string Path::getFilenameExtensionInLowerCase(const std::string &path)`
`126`	`126`	`return extension;`
`127`	`127`	`}`
`128`	`128`
`129`		`-const std::string Path::getCurrentPath()`
	`129`	`+std::string Path::getCurrentPath()`
`130`	`130`	`{`
`131`	`131`	`char currentPath[4096];`
`132`	`132`