Skip to content

Hello PR from Taiwan#115

Merged
wesbos merged 1 commit into
wesbos:masterfrom
amelieyeh:hello-from-taiwan
Feb 23, 2017
Merged

Hello PR from Taiwan#115
wesbos merged 1 commit into
wesbos:masterfrom
amelieyeh:hello-from-taiwan

Conversation

@amelieyeh

@amelieyeh amelieyeh commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

Hi, @wesbos here is my PR. Please let me know if there is any issues, thank you 😄
Amelie 😄

… thank you!

👋👋👋👋👋👋👋👋👋👋👋👋👋👋
👋👋👋Hello Friend!👋👋👋👋
👋👋👋👋👋👋👋👋👋👋👋👋👋👋

Thanks for Submitting a pull request. Before you hit that button please make sure:

These files are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things or fixed a small bug, that is great great, but I will be keeping them the same as the videos to avoid confusing.

Spelling mistakes / CSS updates / other clarifications are welcome as long as they don't change what is shown in the videos.

I encourage you to blog about your implementation and add the link to this repo - that way everyone can benefit from it.

@amelieyeh amelieyeh changed the title Hello PR from Taiwan#1. Hello PR from Taiwan Feb 23, 2017
@wesbos wesbos merged commit cfb9276 into wesbos:master Feb 23, 2017
@wesbos

wesbos commented Feb 23, 2017

Copy link
Copy Markdown
Owner

thanks!

EmmDguez pushed a commit to EmmDguez/JavaScript30 that referenced this pull request Jun 10, 2018
bSkinny2 pushed a commit to bSkinny2/JavaScript30 that referenced this pull request Mar 20, 2024
Added hint to README.md Instructions
FredTheJanitor pushed a commit to FredTheJanitor/JavaScript30 that referenced this pull request May 29, 2026
FredTheJanitor pushed a commit to FredTheJanitor/JavaScript30 that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants