direct fetch: when cancelling due to redirect, read full body#688
Merged
direct fetch: when cancelling due to redirect, read full body#688
Conversation
…id possible exception due to encoding fixes #687
tw4l
approved these changes
Sep 17, 2024
Member
tw4l
left a comment
tw4l
left a comment
There was a problem hiding this comment.
Makes sense! Nice to see that undici repo maintainers seem to be moving quickly on the node bug as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid possible exception due to encoding. (Probably a node bug, reported in nodejs/undici#3616)
Replace abort with cancel, which is the recommended way to cancel the response.
fixes #687