fix: polish waitForClickable #14744
Merged
fix: polish waitForClickable #14744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wswebcreation
added
the
PR: Polish 💅
erwinheitzman
approved these changes
Sep 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling to prevent the waitForClickable command from being used in native mobile app contexts, where it is not supported. The change ensures consistent behavior between isClickable and waitForClickable commands.
- Adds native context validation to
waitForClickablecommand - Updates documentation to clarify browser-only support
- Adds comprehensive test coverage for the new validation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/webdriverio/src/commands/element/waitForClickable.ts | Adds native context check and throws error for mobile native apps, updates JSDoc |
| packages/webdriverio/src/commands/element/isClickable.ts | Removes outdated comment about Appium platform support |
| packages/webdriverio/tests/commands/element/waitForClickable.test.ts | Adds test case to verify error is thrown in native context |
| mocks/fetch.ts | Updates mock to handle Android platform capabilities and removes browserVersion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
waitForClickableshould not work for native apps, so we throw an error for nowTypes of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers