GUI: Failed to start default Notepad++.

kimmov · kimmov · commit 16fe2f8802df · 2010-10-28T22:54:30.000+03:00
Notepad++ found and set as editor by default failed to start. There
were no quotation marks around path containing space chars.
diff --git a/gui/applicationlist.cpp b/gui/applicationlist.cpp
@@ -59,7 +59,7 @@ void ApplicationList::LoadSettings(QSettings *programSettings)
             const QString appPath(getenv("ProgramFiles"));
             if (!appPath.isNull() && QFileInfo(appPath + "\\Notepad++\\notepad++.exe").isExecutable())
             {
-                AddApplicationType("Notepad++", QString(appPath) + "\\Notepad++\\notepad++.exe -n(line) (file)");
+                AddApplicationType("Notepad++", "\"" + QString(appPath) + "\\Notepad++\\notepad++.exe\" -n(line) (file)");
                 break;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ void ApplicationList::LoadSettings(QSettings *programSettings)`
`59`	`59`	`const QString appPath(getenv("ProgramFiles"));`
`60`	`60`	`if (!appPath.isNull() && QFileInfo(appPath + "\\Notepad++\\notepad++.exe").isExecutable())`
`61`	`61`	`{`
`62`		`- AddApplicationType("Notepad++", QString(appPath) + "\\Notepad++\\notepad++.exe -n(line) (file)");`
	`62`	`+ AddApplicationType("Notepad++", "\"" + QString(appPath) + "\\Notepad++\\notepad++.exe\" -n(line) (file)");`
`63`	`63`	`break;`
`64`	`64`	`}`
`65`	`65`	`}`