GcmParams and extend KeyEncryptionAlgorithm with EC derive schemas from CMS #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Extensions for #293 |
Author
|
Helps with support for #278 |
Author
|
Is there a chance that this moves on? It would be a shame to move it to my project. |
Contributor
|
I don't have merge access on this repository, and as far as I know @wbond is the only person who can cut releases, so I can't help you directly. I've also resorted to registering mappings at runtime in asn1crypto for a number of things (and that includes some niche pyHanko features). So far the burden of maintaining those live patches is less than the effort it'd take to maintain a fork of this lib. Not exactly ideal, but it's the least bad option for me currently 🤷♂️ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing encrypted messages with CMS I noticed that the schemas for wrapping keys with EC key derive. Also the encryption/wrap could not be described when using GCM mode. Both are implemented with tests from RFC 5753 example byte values.