Conversation
|
@RByers , could you kindly review the PR? |
|
Ah, I have found that this change is wrong and should be updated. |
|
I have updated the PR. PTAL. |
|
Sorry for the delay! I have to run now, but I will look tomorrow. |
index.html
Outdated
| <a href="https://github.com/w3c/touch-events/pull/72">Note about avoiding conditional "touch OR mouse/keyboard" event handling</a> | ||
| </li> | ||
| <li> | ||
| Added TouchEvent's retargeting steps. |
There was a problem hiding this comment.
nit: add a link to the pull request please
|
This makes sense and ended up being much simpler than I expected given the code I've seen in blink for this . LGTM with a tiny nit. |
Upstream Shadow DOM's TouchEvent's retargeting to TouchEvent specification. http://w3c.github.io/webcomponents/spec/shadow/#touch-events-retargeting DOM Standard side issue is here: whatwg/dom#286. DOM Standard already defines a necessary hook, https://dom.spec.whatwg.org/#event-retargeting-steps. The test for TouchEvent retargeting was commited at web-platform-tests/wpt#3425.
hayatoito
force-pushed
the
retargeting
branch
from
7e5ce8e to
792c730
Compare
|
Thanks for the review. I have added a link to the pull req in the change. |
|
Thank you! And especially thanks for updating the tests! |
2 participants
Upstream Shadow DOM's TouchEvent's retargeting to TouchEvent specification.
http://w3c.github.io/webcomponents/spec/shadow/#touch-events-retargeting
DOM Standard side issue is here: whatwg/dom#286.
DOM Standard already defines a necessary hook, https://dom.spec.whatwg.org/#event-retargeting-steps.
The test for TouchEvent retargeting was commited at web-platform-tests/wpt#3425.