feat: added keyword and built-in completion#490
Merged
JalonSolov merged 2 commits intovlang:masterfrom Mar 22, 2026
Merged
Conversation
JalonSolov
reviewed
Mar 22, 2026
| const v_builtins = ['close', 'copy', 'eprintln', 'eprint', 'error', 'error_with_code', 'exit', | ||
| 'flush_stderr', 'flush_stdout', 'free', 'isnil', 'panic', 'print', 'println'] | ||
|
|
||
| fn make_keyword_completions() []Detail { |
Contributor
There was a problem hiding this comment.
Hard-coding these seems like a "code smell". I know the lists shouldn't change that much, but isn't there a way to get this info from the compiler, instead?
Contributor
Author
There was a problem hiding this comment.
Yeah I believe we'll need to add a compiler flag to get that info.
Contributor
There was a problem hiding this comment.
Personally, that would be my preference. Perhaps the current JSON output could be modified to include the type, rather than needing to add a new option.
If it already includes the type, then vls isn't using it. :-\
Contributor
Author
There was a problem hiding this comment.
Ok I'll try that. 👍
Contributor
|
Conflict to resolve after other PR merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Keywords
Built-in functions (example println)