Skip to content

Commit 0f2807b

Browse files
iseppalaiseppala
committed
Hexagonal pattern: More descriptive class names
1 parent 1b10ddb commit 0f2807b

13 files changed

Lines changed: 158 additions & 210 deletions

File tree

‎hexagonal/etc/hexagonal.png‎

-16.9 KB
Loading

‎hexagonal/etc/hexagonal.ucls‎

Lines changed: 126 additions & 171 deletions
Large diffs are not rendered by default.

‎hexagonal/src/main/java/com/iluwatar/hexagonal/App.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import com.google.inject.Guice;
3030
import com.google.inject.Injector;
3131
import com.iluwatar.hexagonal.administration.LotteryAdministration;
32-
import com.iluwatar.hexagonal.banking.WireTransfersImpl;
32+
import com.iluwatar.hexagonal.banking.InMemoryBank;
3333
import com.iluwatar.hexagonal.domain.LotteryConstants;
3434
import com.iluwatar.hexagonal.domain.LotteryNumbers;
3535
import com.iluwatar.hexagonal.domain.LotteryTicket;
@@ -112,7 +112,7 @@ public class App {
112112
PLAYERS.add(PlayerDetails.create("[email protected]", "637-738", "+09842354"));
113113
PLAYERS.add(PlayerDetails.create("[email protected]", "143-947", "+375245"));
114114
PLAYERS.add(PlayerDetails.create("[email protected]", "842-404", "+131243252"));
115-
WireTransfersImpl wireTransfers = new WireTransfersImpl();
115+
InMemoryBank wireTransfers = new InMemoryBank();
116116
Random random = new Random();
117117
for (int i = 0; i < PLAYERS.size(); i++) {
118118
wireTransfers.setFunds(PLAYERS.get(i).getBankAccount(),

‎hexagonal/src/main/java/com/iluwatar/hexagonal/LotteryModule.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,29 +24,29 @@
2424

2525
import com.google.inject.AbstractModule;
2626
import com.iluwatar.hexagonal.administration.LotteryAdministration;
27-
import com.iluwatar.hexagonal.administration.LotteryAdministrationImpl;
27+
import com.iluwatar.hexagonal.administration.ConsoleAdministration;
28+
import com.iluwatar.hexagonal.banking.InMemoryBank;
2829
import com.iluwatar.hexagonal.banking.WireTransfers;
29-
import com.iluwatar.hexagonal.banking.WireTransfersImpl;
30-
import com.iluwatar.hexagonal.database.LotteryTicketInMemoryRepository;
30+
import com.iluwatar.hexagonal.database.InMemoryTicketRepository;
3131
import com.iluwatar.hexagonal.database.LotteryTicketRepository;
3232
import com.iluwatar.hexagonal.domain.LotterySystem;
3333
import com.iluwatar.hexagonal.domain.LotterySystemImpl;
3434
import com.iluwatar.hexagonal.notifications.LotteryNotifications;
35-
import com.iluwatar.hexagonal.notifications.LotteryNotificationsImpl;
35+
import com.iluwatar.hexagonal.notifications.StdOutNotifications;
36+
import com.iluwatar.hexagonal.service.ConsoleService;
3637
import com.iluwatar.hexagonal.service.LotteryService;
37-
import com.iluwatar.hexagonal.service.LotteryServiceImpl;
3838

3939
/**
4040
* Guice module for binding production dependencies
4141
*/
4242
public class LotteryModule extends AbstractModule {
4343
@Override
4444
protected void configure() {
45-
bind(LotteryTicketRepository.class).to(LotteryTicketInMemoryRepository.class);
45+
bind(LotteryTicketRepository.class).to(InMemoryTicketRepository.class);
4646
bind(LotterySystem.class).to(LotterySystemImpl.class);
47-
bind(LotteryNotifications.class).to(LotteryNotificationsImpl.class);
48-
bind(WireTransfers.class).to(WireTransfersImpl.class);
49-
bind(LotteryAdministration.class).to(LotteryAdministrationImpl.class);
50-
bind(LotteryService.class).to(LotteryServiceImpl.class);
47+
bind(LotteryNotifications.class).to(StdOutNotifications.class);
48+
bind(WireTransfers.class).to(InMemoryBank.class);
49+
bind(LotteryAdministration.class).to(ConsoleAdministration.class);
50+
bind(LotteryService.class).to(ConsoleService.class);
5151
}
5252
}

hexagonal/src/main/java/com/iluwatar/hexagonal/administration/LotteryAdministrationImpl.java renamed to hexagonal/src/main/java/com/iluwatar/hexagonal/administration/ConsoleAdministration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@
3535
* Lottery administration implementation
3636
*
3737
*/
38-
public class LotteryAdministrationImpl implements LotteryAdministration {
38+
public class ConsoleAdministration implements LotteryAdministration {
3939

4040
private final LotterySystem lotterySystem;
4141

4242
@Inject
43-
public LotteryAdministrationImpl(LotterySystem lotterySystem) {
43+
public ConsoleAdministration(LotterySystem lotterySystem) {
4444
this.lotterySystem = lotterySystem;
4545
}
4646

hexagonal/src/main/java/com/iluwatar/hexagonal/banking/WireTransfersImpl.java renamed to hexagonal/src/main/java/com/iluwatar/hexagonal/banking/InMemoryBank.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* Banking implementation
3333
*
3434
*/
35-
public class WireTransfersImpl implements WireTransfers {
35+
public class InMemoryBank implements WireTransfers {
3636

3737
private static Map<String, Integer> accounts = new HashMap<>();
3838

hexagonal/src/main/java/com/iluwatar/hexagonal/database/LotteryTicketInMemoryRepository.java renamed to hexagonal/src/main/java/com/iluwatar/hexagonal/database/InMemoryTicketRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* Mock database for lottery tickets.
3535
*
3636
*/
37-
public class LotteryTicketInMemoryRepository implements LotteryTicketRepository {
37+
public class InMemoryTicketRepository implements LotteryTicketRepository {
3838

3939
private static Map<LotteryTicketId, LotteryTicket> tickets = new HashMap<>();
4040

hexagonal/src/main/java/com/iluwatar/hexagonal/notifications/LotteryNotificationsImpl.java renamed to hexagonal/src/main/java/com/iluwatar/hexagonal/notifications/StdOutNotifications.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
import com.iluwatar.hexagonal.domain.PlayerDetails;
2626

27-
public class LotteryNotificationsImpl implements LotteryNotifications {
27+
public class StdOutNotifications implements LotteryNotifications {
2828

2929
@Override
3030
public void notifyTicketSubmitted(PlayerDetails details) {

hexagonal/src/main/java/com/iluwatar/hexagonal/service/LotteryServiceImpl.java renamed to hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@
3636
* Implementation for lottery service
3737
*
3838
*/
39-
public class LotteryServiceImpl implements LotteryService {
39+
public class ConsoleService implements LotteryService {
4040

4141
private final LotterySystem lotterySystem;
4242

4343
/**
4444
* Constructor
4545
*/
4646
@Inject
47-
public LotteryServiceImpl(LotterySystem lotterySystem) {
47+
public ConsoleService(LotterySystem lotterySystem) {
4848
this.lotterySystem = lotterySystem;
4949
}
5050

‎hexagonal/src/test/java/com/iluwatar/hexagonal/LotteryTestingModule.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,30 +23,30 @@
2323
package com.iluwatar.hexagonal;
2424

2525
import com.google.inject.AbstractModule;
26+
import com.iluwatar.hexagonal.administration.ConsoleAdministration;
2627
import com.iluwatar.hexagonal.administration.LotteryAdministration;
27-
import com.iluwatar.hexagonal.administration.LotteryAdministrationImpl;
28+
import com.iluwatar.hexagonal.banking.InMemoryBank;
2829
import com.iluwatar.hexagonal.banking.WireTransfers;
29-
import com.iluwatar.hexagonal.banking.WireTransfersImpl;
30-
import com.iluwatar.hexagonal.database.LotteryTicketInMemoryRepository;
30+
import com.iluwatar.hexagonal.database.InMemoryTicketRepository;
3131
import com.iluwatar.hexagonal.database.LotteryTicketRepository;
3232
import com.iluwatar.hexagonal.domain.LotterySystem;
3333
import com.iluwatar.hexagonal.domain.LotterySystemImpl;
3434
import com.iluwatar.hexagonal.notifications.LotteryNotifications;
35-
import com.iluwatar.hexagonal.notifications.LotteryNotificationsImpl;
35+
import com.iluwatar.hexagonal.notifications.StdOutNotifications;
36+
import com.iluwatar.hexagonal.service.ConsoleService;
3637
import com.iluwatar.hexagonal.service.LotteryService;
37-
import com.iluwatar.hexagonal.service.LotteryServiceImpl;
3838

3939
/**
4040
* Guice module for testing dependencies
4141
*/
4242
public class LotteryTestingModule extends AbstractModule {
4343
@Override
4444
protected void configure() {
45-
bind(LotteryTicketRepository.class).to(LotteryTicketInMemoryRepository.class);
45+
bind(LotteryTicketRepository.class).to(InMemoryTicketRepository.class);
4646
bind(LotterySystem.class).to(LotterySystemImpl.class);
47-
bind(LotteryNotifications.class).to(LotteryNotificationsImpl.class);
48-
bind(WireTransfers.class).to(WireTransfersImpl.class);
49-
bind(LotteryAdministration.class).to(LotteryAdministrationImpl.class);
50-
bind(LotteryService.class).to(LotteryServiceImpl.class);
47+
bind(LotteryNotifications.class).to(StdOutNotifications.class);
48+
bind(WireTransfers.class).to(InMemoryBank.class);
49+
bind(LotteryAdministration.class).to(ConsoleAdministration.class);
50+
bind(LotteryService.class).to(ConsoleService.class);
5151
}
5252
}

0 commit comments

Comments
 (0)