Fix error check of 'rop'#2413
Closed
k-takata wants to merge 1 commit into
Closed
Conversation
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
…g GUI
Problem: No error when settting 'renderoptions' to an invalid value before
starting the GUI.
Solution: Always check the value. (Ken Takata, closes vim#2413)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, error check of the 'renderoptions' option is inconsistent.
If a wrong value is set to 'rop' after boot up, E474 error is shown.
However, if a wrong value is set in .vimrc or .gvimrc, the error is not shown.
I think this should be an error for consistency.