Feature/430 vda xp reward client create #440
Conversation
- Added contract address and abi of `vda-xp-reward`
- Fix typos
| * @param to - Recipient wallet address | ||
| * @param amount - Token amount to be withdrawn | ||
| */ | ||
| public async withdraw( |
There was a problem hiding this comment.
In face, no need deposit() method.
The owner can deposit tokens by send the VDA token to the address of XPReward contract.
If we added deposit() function in the XPReward contract, the owner should approve the VDA token to the contract before calling the deposit() function. This involves 2 step for depositing.
I think, transferring VDA token to the XPReward contract is more conveninent.
There was a problem hiding this comment.
I'm proposing adding a deposit() method to this typescript library, not the smart contract.
A user of this typescript library needs a way to easily deposit tokens.
There was a problem hiding this comment.
Added depositToken() function
| @@ -0,0 +1,7 @@ | |||
| ## These are used for test only. | |||
| PRIVATE_KEY = "<Input private key of transaction sender>" | |||
| RPC_URL="<Input RPC url for targeting chain>" | |||
There was a problem hiding this comment.
We can remove this now as it should use default RPC URLs
There was a problem hiding this comment.
Just not clear.
PRIVATE_KEY is the private key of wallet that send the transaction.
And the RPC_URL is used in the tes script to manage the mock token.
There was a problem hiding this comment.
If the RPC_URL is only for the. test script, then make that clear. Add a comment in .env.example and maybe rename to RPC_URL_TEST_DEPLOY
There was a problem hiding this comment.
There is comment in the .env.example file.
- Added contract address and abi of `vda-xp-reward`
- Fix typos
- Updated the `XPRewardContract` address and abi
- Update on review - Added `depositToke()` function
…verida/verida-js into feature/430-vda-xp-reward-client-create
Initial version of
vda-xp-reward-client