Closed
Conversation
These tests are derived from the following files within the Google V8 project: test/mjsunit/es6/string-html.js
Contributor
Author
|
Whoops! Sorry! |
jugglinmike
referenced
this pull request
in bocoup/v8-git-mirror
Mar 3, 2015
…patchset #3 id:40001 of https://codereview.chromium.org/955063002/) Reason for revert: Breaks test/mjsunit/debug-clearbreakpointgroup.js on arm64.debug. Original issue's description: > Fix memory leak caused by field type in descriptor array. > > When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. > > Map::GetFieldType(i) does the unwrapping. > > BUG=v8:3877 > LOG=N > TEST=cctest/test-heap/Regress3877 > > Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e > Cr-Commit-Position: refs/heads/master@{#26879} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3877 Review URL: https://codereview.chromium.org/960103003 Cr-Commit-Position: refs/heads/master@{#26883}
jugglinmike
referenced
this pull request
in bocoup/v8-git-mirror
Mar 3, 2015
…://codereview.chromium.org/962263002/) Reason for revert: Fails on nosnap build Original issue's description: > Disallow subclassing Arrays. > > [email protected],[email protected] > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/87f3e08e72510ee5544e82bb7ad39b2b5f001ad3 > Cr-Commit-Position: refs/heads/master@{#26925} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/965053002 Cr-Commit-Position: refs/heads/master@{#26930}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 6, 2015
…set v8#3 id:100001 of https://codereview.chromium.org/976203003/) Reason for revert: Some tests still flaky Original issue's description: > CpuProfiler: enable tests except four failing tests. > > Four tests are failing due to a problem with no frame ranges. > > BUG= > LOG=n > > Committed: https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1 > Cr-Commit-Position: refs/heads/master@{#27035} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/987553005 Cr-Commit-Position: refs/heads/master@{#27037}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 16, 2015
…he StoreBuffer/SlotsBuffer. (patchset v8#3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Review URL: https://codereview.chromium.org/1004623003 Cr-Commit-Position: refs/heads/master@{#27207}
hashseed
added a commit
that referenced
this pull request
Mar 16, 2015
Merged 52cb51f Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) BUG=chromium:454297,chromium:465273 LOG=N [email protected] Review URL: https://codereview.chromium.org/1012653002 Cr-Commit-Position: refs/heads/4.3.40@{#2} Cr-Branched-From: 11d4bb9-refs/heads/master@{#27198}
jeisinger
added a commit
that referenced
this pull request
Mar 20, 2015
Merged 877c99f Don't DCHECK that the weak closure wasn't yet overapproximated BUG=chromium:469023 LOG=N [email protected] Review URL: https://codereview.chromium.org/1024853002 Cr-Commit-Position: refs/heads/4.3.48@{#3} Cr-Branched-From: 7ccdbcf-refs/heads/master@{#27312}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
…0001 of https://codereview.chromium.org/861223002/) Reason for revert: Still missing these builders: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20full%20debug Original issue's description: > Reland Make clang the default on linux. > > BUG= > > Committed: https://crrev.com/72ef6843b0aff68e519a8f26e7d2f7dd87b4712c > Cr-Commit-Position: refs/heads/master@{#26204} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/864093004 Cr-Commit-Position: refs/heads/master@{#26205}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
…id:40001 of https://codereview.chromium.org/876613002/) Reason for revert: Test failures Original issue's description: > Only use FreeSpace objects in the free list. > > This solves an issue with the custom startup snapshot, in cases where > deserializing the isolate requires more than one page per space. > > [email protected] > > Committed: https://crrev.com/66964395108f03220cb6f45ddc73c5965e2c76a9 > Cr-Commit-Position: refs/heads/master@{#26285} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/882443004 Cr-Commit-Position: refs/heads/master@{#26287}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
…review.chromium.org/886473005/) Reason for revert: Broke compilation on component build http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5007/steps/compile/logs/stdio Original issue's description: > Add WeakMap to v8.h > > A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. > > BUG=chromium:437416 > LOG=Y > > Committed: https://crrev.com/37d4c57630636f21e3add8d3d1c7c978ff5fc8e0 > Cr-Commit-Position: refs/heads/master@{#26401} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437416 Review URL: https://codereview.chromium.org/898763002 Cr-Commit-Position: refs/heads/master@{#26402}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
1) create beefy RelocInfo table when cpu profiler is active, so if a function
was optimized when profiler was active RelocInfo would get separate DeoptInfo
for the each deopt case.
2) push DeoptInfo from CodeEntry to ProfileNode.
When deopt happens we put the info collected on #1 into CodeEntry and record stack sample.
On the sampling thread we grab the deopt data and append it to the corresponding ProfileNode deopts list.
Sample profile dump.
[Top down]:
0 (root) 0 #1
1 29 v8#2
5 test 29 v8#3
3 opt_function 29 v8#4
deopted at 52 with reason 'not a heap number'
deopted at 71 with reason 'division by zero'
BUG=452067
LOG=n
Review URL: https://codereview.chromium.org/919953002
Cr-Commit-Position: refs/heads/master@{#26615}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
…chset #1 id:1 of https://codereview.chromium.org/919953002/) Reason for revert: static initializers broke the build Original issue's description: > CPUProfiler: Push deopt reason further to ProfileNode. > > 1) create beefy RelocInfo table when cpu profiler is active, so if a function > was optimized when profiler was active RelocInfo would get separate DeoptInfo > for the each deopt case. > > 2) push DeoptInfo from CodeEntry to ProfileNode. > When deopt happens we put the info collected on #1 into CodeEntry and record stack sample. > On the sampling thread we grab the deopt data and append it to the corresponding ProfileNode deopts list. > > Sample profile dump. > [Top down]: > 0 (root) 0 #1 > 1 29 v8#2 > 5 test 29 v8#3 > 3 opt_function 29 v8#4 > deopted at 52 with reason 'not a heap number' > deopted at 71 with reason 'division by zero' > > BUG=452067 > LOG=n > > Committed: https://crrev.com/ce8701b247d3c6604f24f17a90c02d17b4417f54 > Cr-Commit-Position: refs/heads/master@{#26615} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Review URL: https://codereview.chromium.org/915173005 Cr-Commit-Position: refs/heads/master@{#26616}
trevnorris
pushed a commit
to nubjs/v8-git-mirror
that referenced
this pull request
Mar 23, 2015
1) create beefy RelocInfo table when cpu profiler is active, so if a function
was optimized when profiler was active RelocInfo would get separate DeoptInfo
for the each deopt case.
2) push DeoptInfo from CodeEntry to ProfileNode.
When deopt happens we put the info collected on #1 into CodeEntry and record stack sample.
On the sampling thread we grab the deopt data and append it to the corresponding ProfileNode deopts list.
Sample profile dump.
[Top down]:
0 (root) 0 #1
1 29 v8#2
1 test 29 v8#3
2 opt_function 29 v8#4
2 opt_function 29 v8#5
deopted at 118 with reason 'not a heap number'
deopted at 137 with reason 'division by zero'
BUG=452067
LOG=n
Committed: https://crrev.com/ce8701b247d3c6604f24f17a90c02d17b4417f54
Cr-Commit-Position: refs/heads/master@{#26615}
Review URL: https://codereview.chromium.org/919953002
Cr-Commit-Position: refs/heads/master@{#26630}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 24, 2015
v8#3 id:40001 of https://codereview.chromium.org/1014813003/) Reason for revert: Layout test failures. Please update layout test expectations before landing this, in order to not block the roll. Original issue's description: > [es6] Object.getPrototypeOf should work with values > > The final spec for Object.getPrototypeOf calls ToObject on the > parameter, which means that it should only throw for null and > undefined. For other non object values the prototype of the wrapper > should be used. > > BUG=v8:3964 > LOG=N > R=adamk, [email protected] > > Committed: https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c > Cr-Commit-Position: refs/heads/master@{#27354} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3964 Review URL: https://codereview.chromium.org/1033623002 Cr-Commit-Position: refs/heads/master@{#27389}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 24, 2015
… of https://codereview.chromium.org/1022333004/) Reason for revert: [Sheriff] This seems to change layout test expectations of some tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317 Expectation example: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html Please add a needsmanualrebaseline expectation to the tests affected by this change on the blink side first before relanding. Original issue's description: > [V8] Removed SourceLocationRestrict > > This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. > Method looks obsolete. > One of the strange side effect is shown by attached issue. > > BUG=chromium:468781 > [email protected] > LOG=Y > > Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf > Cr-Commit-Position: refs/heads/master@{#27374} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468781 Review URL: https://codereview.chromium.org/1028413002 Cr-Commit-Position: refs/heads/master@{#27398}
hubot
pushed a commit
that referenced
this pull request
Mar 26, 2015
Merged c290007 Don't start marking while sweeping [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1003963005 Cr-Commit-Position: refs/heads/4.3.57@{#3} Cr-Branched-From: aca928b-refs/heads/master@{#27458}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 1, 2015
…s://codereview.chromium.org/1041483004/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Fix JSON parser Handle leak > > [email protected] > BUG=v8:3976 > LOG=y > > Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa > Cr-Commit-Position: refs/heads/master@{#27512} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3976 Review URL: https://codereview.chromium.org/1052593002 Cr-Commit-Position: refs/heads/master@{#27562}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 1, 2015
…buffers (patchset v8#3 id:40001 of https://codereview.chromium.org/1035763002/) Reason for revert: Got one dev-channel with this. Should be enough. Original issue's description: > Add CHECKs when updating pointers from the slots and store buffers > > We want to verify that we always overwrite heap objects with heap > objects, and non-heap objects with non-heap objects > > BUG=chromium:452095 > [email protected] > LOG=n > > Committed: https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 > Cr-Commit-Position: refs/heads/master@{#27479} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452095 Review URL: https://codereview.chromium.org/1052713002 Cr-Commit-Position: refs/heads/master@{#27565}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 13, 2015
… a vector. (patchset v8#3 id:40001 of https://codereview.chromium.org/1067573003/) Reason for revert: [Sheriff] Speculative revert for windows failure... will reland if it doesn't help: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%202/builds/2891 Original issue's description: > VectorICs: megamorphic keyed loads in crankshaft don't need a vector. > > They are content with a dummy vector, as MISSES won't result in > changing the real vector/slot at all. > > BUG= > > Committed: https://crrev.com/c8e4d57d3b3036a05902f5b916cb5d853a57393c > Cr-Commit-Position: refs/heads/master@{#27788} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1060263003 Cr-Commit-Position: refs/heads/master@{#27790}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 21, 2015
…(patchset v8#3 id:40001 of https://codereview.chromium.org/1094333002/) Reason for revert: Breaks gbemu Original issue's description: > Reland "LayoutDescriptor should inherit from JSTypedArray" > > Original issue's description: > > LayoutDescriptor should inherit from JSTypedArray > > > > It can't just inherit from a FixedTypedArray-like type, as we soon > > assume that a FixedTypedArray-like type is always held by an > > ArrayBufferView-like type > > > > BUG=v8:3996 > > [email protected],[email protected] > > LOG=n > > BUG=v8:3996 > [email protected],[email protected] > LOG=n [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1080403004 Cr-Commit-Position: refs/heads/master@{#27975}
hubot
pushed a commit
that referenced
this pull request
Apr 30, 2015
Merged 66f428d Bump Isolate::New back to deprecate soon [email protected] BUG= Review URL: https://codereview.chromium.org/1111033003 Cr-Commit-Position: refs/heads/4.4.45@{#3} Cr-Branched-From: 58b0023-refs/heads/master@{#28134}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 6, 2015
…tps://codereview.chromium.org/1073953006/) Reason for revert: Various performance regressions. Original issue's description: > New insertion write barrier. > > BUG= > > Committed: https://crrev.com/6e9e2c08292b553602c74b16b8ccff4e4ccac003 > Cr-Commit-Position: refs/heads/master@{#28199} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131583002 Cr-Commit-Position: refs/heads/master@{#28265}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 7, 2015
…:40001 of https://codereview.chromium.org/1125003002/) Reason for revert: [Sheriff] This causes layout test crashes: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2735 You can add the trybot v8_linux_layout_dbg on reland. Original issue's description: > Use CLOCK_REALTIME_COARSE when available. > > On systems that have CLOCK_REALTIME_COARSE with good enough resolution, we can > avoid making a system call to get the current time; it's serviced from the vDSO. > > BUG= > LOG=N > > Committed: https://crrev.com/537ed7500c087786f28f51ff5222f1c2113776d3 > Cr-Commit-Position: refs/heads/master@{#28280} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1130083003 Cr-Commit-Position: refs/heads/master@{#28288}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 12, 2015
…t require debugger to be active (patchset v8#3 id:40001 of https://codereview.chromium.org/1126103006/) Reason for revert: GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio Original issue's description: > Provide accessor for object internal properties that doesn't require debugger to be active > > Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. > > Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. > > BUG=chromium:481845 > LOG=Y > > Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > Cr-Commit-Position: refs/heads/master@{#28362} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481845 Review URL: https://codereview.chromium.org/1133243002 Cr-Commit-Position: refs/heads/master@{#28365}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 21, 2015
…arking with (patchset v8#3 id:40001 of https://codereview.chromium.org/1156463002/) Reason for revert: [Sheriff] Speculative revert because chromebook is really misbehaving: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. Original issue's description: > Pass GC flags to incremental marker and start incremental marking with > reduce memory footprint in idle notification. > > BUG= > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > Cr-Commit-Position: refs/heads/master@{#28567} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1151143002 Cr-Commit-Position: refs/heads/master@{#28568}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 22, 2015
…remental marking with (patchset #1 id:1 of https://codereview.chromium.org/1151143002/) Reason for revert: Wasn't the reason... Original issue's description: > Revert of Pass GC flags to incremental marker and start incremental marking with (patchset v8#3 id:40001 of https://codereview.chromium.org/1156463002/) > > Reason for revert: > [Sheriff] Speculative revert because chromebook is really misbehaving: > http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 > > I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. > > Original issue's description: > > Pass GC flags to incremental marker and start incremental marking with > > reduce memory footprint in idle notification. > > > > BUG= > > > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > > Cr-Commit-Position: refs/heads/master@{#28567} > > [email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 > Cr-Commit-Position: refs/heads/master@{#28568} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1157613002 Cr-Commit-Position: refs/heads/master@{#28569}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 22, 2015
…0001 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > [email protected] > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
May 26, 2015
… #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset v8#3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > [email protected] > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > [email protected],[email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jun 24, 2015
…set v8#3 id:40001 of https://codereview.chromium.org/1202963005/) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream blink first. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/574 Please consider extra blink trybots on a reland. Original issue's description: > Fix receiver when calling eval() bound by with scope > > Thanks to André Bargull for the report. > > BUG=v8:4214 > LOG=N > [email protected], [email protected] > > Committed: https://crrev.com/3c5f0db3a1768ade68108bf003676ce378d1cbdc > Cr-Commit-Position: refs/heads/master@{#29259} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4214 Review URL: https://codereview.chromium.org/1201273004 Cr-Commit-Position: refs/heads/master@{#29267}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jun 25, 2015
…atchset v8#3 id:40001 of https://codereview.chromium.org/1211453002/) Reason for revert: proxies test failing https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/903/steps/Mjsunit/logs/proxies Original issue's description: > Reland "Keep a canonical list of shared function infos." > > This reverts commit 3164aa7. > > Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 > Cr-Commit-Position: refs/heads/master@{#29282} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1206263002 Cr-Commit-Position: refs/heads/master@{#29285}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 7, 2015
…kers. (patchset v8#3 id:40001 of https://codereview.chromium.org/1215233004/) Reason for revert: [Sheriff] Test hangs sometimes and times out flakily. E.g.: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse3/builds/4551/steps/Check%20%28flakes%29/logs/d8-worker-sharedarray.. Original issue's description: > Fix bug when transferring SharedArrayBuffer to multiple Workers. > > Previously, the serialization code would call Externalize for every transferred > ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If > the buffer is already externalized, we should call GetContents instead. > > Also fix use-after-free bug when transferring ArrayBuffers. The transferred > ArrayBuffer must be internalized in the new isolate, or be managed by the > Shell. The current code gives it to the isolate externalized and frees it > immediately afterward when the SerializationData object is destroyed. > > BUG=chromium:497295 > [email protected] > LOG=n > > Committed: https://crrev.com/dd7962bf7838f8379ba776ee6b7b0e4d3bec2140 > Cr-Commit-Position: refs/heads/master@{#29499} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497295 Review URL: https://codereview.chromium.org/1224843008 Cr-Commit-Position: refs/heads/master@{#29506}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 13, 2015
…ew.chromium.org/1232583002/) Reason for revert: [Sheriff] Looks like another clang option got deprecated: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/326 Original issue's description: > Update V8 DEPS. > > Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c > > Original CL: https://codereview.chromium.org/1232043002/ > > BUG= > > Committed: https://crrev.com/6211e1660492f653d30ddd1336bce6f9083ede94 > Cr-Commit-Position: refs/heads/master@{#29598} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1232803003 Cr-Commit-Position: refs/heads/master@{#29600}
hubot
pushed a commit
that referenced
this pull request
Jul 13, 2015
Merged 4a4d836 [es6] unship harmony_rest_parameters BUG=chromium:508074 LOG=N [email protected] NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1227863004 Cr-Commit-Position: refs/branch-heads/4.5@{#3} Cr-Branched-From: 7f21153-refs/heads/4.5.103@{#1} Cr-Branched-From: 4b38c15-refs/heads/master@{#29527}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 17, 2015
…xt. (patchset v8#3 id:40001 of https://codereview.chromium.org/1239033002/) Reason for revert: breaks roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/87292/steps/browser_tests%20%28with%20patch%29/logs/DevToolsSanityTest.TestPauseWhenScriptIsRunning Original issue's description: > Debugger: use FrameInspector in ScopeIterator to find context. > > In optimized code, it's not guaranteed that the current context > is stored in its frame slot. > > [email protected] > BUG=v8:4309 > LOG=N > > Committed: https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38 > Cr-Commit-Position: refs/heads/master@{#29697} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4309 Review URL: https://codereview.chromium.org/1243553002 Cr-Commit-Position: refs/heads/master@{#29722}
hubot
pushed a commit
that referenced
this pull request
Jul 17, 2015
Merged c062b28 Revert of Debugger: use FrameInspector in ScopeIterator to find context. (patchset #3 id:40001 of https://codereview.chromium.org/1239033002/) BUG=v8:4309 LOG=N [email protected], [email protected] Review URL: https://codereview.chromium.org/1244583002 . Cr-Commit-Position: refs/heads/4.6.12@{#2} Cr-Branched-From: ecf1c86-refs/heads/master@{#29704}
hubot
pushed a commit
that referenced
this pull request
Jul 17, 2015
Merged c062b28 Revert of Debugger: use FrameInspector in ScopeIterator to find context. (patchset #3 id:40001 of https://codereview.chromium.org/1239033002/) BUG=v8:4309 LOG=N [email protected], [email protected] Review URL: https://codereview.chromium.org/1228763006 . Cr-Commit-Position: refs/heads/4.6.13@{#2} Cr-Branched-From: 07dc66d-refs/heads/master@{#29705}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 17, 2015
…40001 of https://codereview.chromium.org/1239053004/) Reason for revert: [Sheriff] Breaks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20code%20serializer/builds/3400 Original issue's description: > Make d8 stop using to-be-deprecated APIs > > BUG=v8:4134 > LOG=n > [email protected] > > Committed: https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 > Cr-Commit-Position: refs/heads/master@{#29726} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4134 Review URL: https://codereview.chromium.org/1240993003 Cr-Commit-Position: refs/heads/master@{#29730}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 5, 2015
…hset #1 id:1 of https://codereview.chromium.org/1265983006/ ) Reason for revert: This still breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/1296/steps/Mjsunit/logs/load-proxy Test: mjsunit/strong/load-proxy Flags: --stress-opt --always-opt Command: out/Debug/d8 --test --random-seed=2021532800 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --harmony-proxies --strong-mode test/mjsunit/strong/load-proxy.js --gc-interval=500 --stress-compaction --concurrent-recompilation-queue-length=64 --concurrent-recompilation-delay=500 --concurrent-recompilation Run #1 Exit code: -11 Result: CRASH Expected outcomes: PASS Duration: 00:00:553 Run v8#2 Exit code: -11 Result: CRASH Expected outcomes: PASS Duration: 00:00:520 Run v8#3 Exit code: -11 Result: CRASH Expected outcomes: PASS Duration: 00:00:572 Original issue's description: > Remove serializer-specific hash table size heuristic. > > The heuristic can cause weird behavior when bootstrapping. > The memory savings is not worth this hassle. > > Committed: https://crrev.com/fc80f29a582b758d14aae864232624ca45e47ddc > Cr-Commit-Position: refs/heads/master@{#30019} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1268413002 Cr-Commit-Position: refs/heads/master@{#30024}
hubot
pushed a commit
that referenced
this pull request
Aug 25, 2015
…d:40001 of https://codereview.chromium.org/1311343002/ ) Reason for revert: https://codereview.chromium.org/1315823004/ Original issue's description: > Array.prototype.unshift builtin improvements > > Moving unshift to ElementAccessor and increasing the range of arguments > handled directly in C++, namely directly supporting FastDoubleElementsKind. > This should yield a factor 19 speedup for unshift on fast double arrays. > > BUG= > > Committed: https://crrev.com/bf6764e6c1197e50ae148755488307a423b1d9b4 > Cr-Commit-Position: refs/heads/master@{#30347} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1311363003 Cr-Commit-Position: refs/heads/master@{#30350}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 25, 2015
[email protected] Review URL: https://codereview.chromium.org/1304873006 Cr-Commit-Position: refs/heads/master@{#30358}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 3, 2015
… (patchset v8#3 id:40001 of https://codereview.chromium.org/1307943013/ ) Reason for revert: [Sheriff] Changes several layout test expectations. Please fix upstream first if intended. E.g.: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/1729 Several lines change from PASS to FAIL. Original issue's description: > [es5] Class of object is "Function" if object has [[Call]]. > > The concept of class was mostly removed from ES6, but we still use the > class of objects to distinguish object kinds in our builtins. So update > this to be in sync with IsCallable (thereby getting rid of the previous > instance type based tests for callable things completely). > > [email protected], [email protected] > > Committed: https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 > Cr-Commit-Position: refs/heads/master@{#30566} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1306303005 Cr-Commit-Position: refs/heads/master@{#30568}
hubot
pushed a commit
that referenced
this pull request
Sep 4, 2015
…0001 of https://codereview.chromium.org/1303033012/ ) Reason for revert: [Sheriff] Breaks fuzzer and msan: http://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/4773 Repro with: tools/fuzz-harness.sh out/Debug/d8 (in a ninja Debug build) Msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/4097 Original issue's description: > Speedup stringsearch for two byte strings > > Uses the lower byte with memchr which is > significantly faster than a naive compare > > Performance difference with bench (http://hastebin.com/xuxexataso.js): > > old new > > single character single character > Κ found at 922 Κ found at 922 > 3324 616 > ㎡ found at 13217 ㎡ found at 13217 > 42366 4931 > က found at 4096 က found at 4096 > 13369 9836 > found at 65280 found at 65280 > 207472 36149 > ᆬ found at 65445 ᆬ found at 65445 > 209344 36666 > found at 8197 found at 8197 > 26731 11757 > 倂 found at 20482 倂 found at 20482 > 66071 17193 > > linear search linear search > ΚΛ found at 922 ΚΛ found at 922 > 4112 504 > ㎡㎢ found at 13217 ㎡㎢ found at 13217 > 55105 5119 > ᆬᆭ found at 65445 ᆬᆭ found at 65445 > 268016 35496 > > linear + bmh search linear + bmh search > ΚΛΜΝΞΟΠΡ found at 922 ΚΛΜΝΞΟΠΡ found at 922 > 2897 522 > ᆬᆭᄃᄄᄅᆰᆱᆲ found at 65445 ᆬᆭᄃᄄᄅᆰᆱᆲ found at 65445 > 167687 158465 > > Committed: https://crrev.com/fced280f37588f8a232a414201276e053117e9ea > Cr-Commit-Position: refs/heads/master@{#30587} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1331433002 Cr-Commit-Position: refs/heads/master@{#30588}
cdai2
added a commit
that referenced
this pull request
Sep 4, 2015
Merged 682365d Merged ab67514 Merged 8116f95 Merged 97a48c5 Merged 0afbd7a Merged 597cfc6 Merged 9726db8 X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. X87: [turbofan] Support unboxed float and double stack parameters and add tests. X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. X87: [turbofan] Unify referencing of stack slots X87: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. X87: Cleanup: Remove unncessary leave_frame parameter from stub cache. X87: Disable test case for X87 because of double register number restriction. [email protected] BUG= Review URL: https://codereview.chromium.org/1315533002 Cr-Commit-Position: refs/branch-heads/4.6@{#3} Cr-Branched-From: 24d34a8-refs/heads/4.6.85@{#1} Cr-Branched-From: 8f44118-refs/heads/master@{#30256}
hubot
pushed a commit
that referenced
this pull request
Sep 4, 2015
Merged 3c1487d Map::ReconfigureProperty() should mark map as unstable when there is an element kind transition somewhere in the middle of the transition tree. BUG=chromium:485548 LOG=N [email protected] Review URL: https://codereview.chromium.org/1149463002 Cr-Commit-Position: refs/branch-heads/4.4@{#3} Cr-Branched-From: 2e4c550-refs/heads/4.4.63@{#1} Cr-Branched-From: 0208b8e-refs/heads/master@{#28333}
hubot
pushed a commit
that referenced
this pull request
Sep 10, 2015
Merged 00477a5 Ensure that GC idle notifications either make progress or stop requesting more GCs. BUG=chromium:470615 LOG=N [email protected] Review URL: https://codereview.chromium.org/1071503002 Cr-Commit-Position: refs/branch-heads/4.3@{#3} Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1} Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}
hubot
pushed a commit
that referenced
this pull request
Sep 11, 2015
This ports https://codereview.chromium.org/959713003/ to the 4.2 branch. BUG=v8:3075 LOG=n [email protected] Review URL: https://codereview.chromium.org/953363002 Cr-Commit-Position: refs/branch-heads/4.2@{#3} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 14, 2015
…v8#3 id:40001 of https://codereview.chromium.org/1336313002/ ) Reason for revert: [Sheriff] Breaks GC stress on mac: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/2536 Original issue's description: > VectorICs: ia32 store ics need a virtual register. > > Some pretty hacky code was used to carry out the tail-call > handler dispatch on ia32 vector stores due to a lack > of free registers. It really tanks performance. A better > approach is to use a virtual register on the isolate. > > BUG= > > Committed: https://crrev.com/b26e98f19b5e77df50cb4a259f099ee6afa335e3 > Cr-Commit-Position: refs/heads/master@{#30718} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1340123002 Cr-Commit-Position: refs/heads/master@{#30719}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 28, 2015
…happy again. (patchset v8#3 id:80001 of https://codereview.chromium.org/1361763004/ ) Reason for revert: This CL breaks cross-compiling to arm. Original issue's description: > Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > Committed: https://crrev.com/0b48b2a8ebfc791a36f4ec1f299f46db76265a3a > Cr-Commit-Position: refs/heads/master@{#30977} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1370203002 Cr-Commit-Position: refs/heads/master@{#30982}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 29, 2015
…id:40001 of https://codereview.chromium.org/1370123002/ ) Reason for revert: Breaks arm64 nosnap simulator (bogus cctest?): https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/2934/steps/Bisect%202786ceec.Retry/logs/IncrementalWriteBarri.. Original issue's description: > [heap] Remove retry space from AllocateRaw. > > BUG= > > Committed: https://crrev.com/2786ceec1eb491494d24d29a59eefbe3b6704be2 > Cr-Commit-Position: refs/heads/master@{#30984} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1379493003 Cr-Commit-Position: refs/heads/master@{#30991}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 29, 2015
…eview.chromium.org/1362333002/ ) Reason for revert: [Sheriff] Seems to break layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2073 https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64/2073/layout-test-results/results.html Please request rebaseline upstream first. Original issue's description: > Clean up rewriter. > > The main changes are: > - Fix treatment of loops, which was incorrect and sometimes resulted in > the wrong completion value. > - Get rid of unnecessary variables. > > This is in preparation of implementing ES6 completion semantics. > > R=rossberg > BUG= > > Committed: https://crrev.com/b466dc14791844b7ae6d1e9ebd00a778965c206d > Cr-Commit-Position: refs/heads/master@{#30981} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1379513002 Cr-Commit-Position: refs/heads/master@{#30992}
hubot
pushed a commit
that referenced
this pull request
Oct 2, 2015
BUG=chromium:318206 LOG=N [email protected],[email protected] NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1374923003 Cr-Commit-Position: refs/branch-heads/4.7@{#3} Cr-Branched-From: f3c8926-refs/heads/master@{#31014}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 5, 2015
…C 4.9.2 happy again. (patchset v8#3 id:40001 of https://codereview.chromium.org/1384873002/ ) Reason for revert: [Sheriff] Breaks the gcc 4.8 bot: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/3274 Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308 > Cr-Commit-Position: refs/heads/master@{#31105} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1376113005 Cr-Commit-Position: refs/heads/master@{#31112}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 8, 2015
…C 4.9.2 happy again. (patchset v8#3 id:40001 of https://codereview.chromium.org/1383053005/ ) Reason for revert: Breaks Arm debug. Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116 > Cr-Commit-Position: refs/heads/master@{#31163} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1398643002 Cr-Commit-Position: refs/heads/master@{#31167}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 12, 2015
…. (patchset v8#3 id:40001 of https://codereview.chromium.org/1392823003/ ) Reason for revert: broken tests Original issue's description: > [heap] Decrease large object limit for regular heap objects. > > Committed: https://crrev.com/e887d42342b3449f64fb6078f84f6c55bae3978d > Cr-Commit-Position: refs/heads/master@{#31217} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1402823002 Cr-Commit-Position: refs/heads/master@{#31219}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 13, 2015
…objects. (patchset v8#3 id:40001 of https://codereview.chromium.org/1401173003/ ) Reason for revert: Still one failing test on Windows. Original issue's description: > [heap] Reland decrease large object limit for regular heap objects. > > BUG= > > Committed: https://crrev.com/9b91bf3a630b5382080ba1d7f9f3e88de3de8a95 > Cr-Commit-Position: refs/heads/master@{#31228} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1395653003 Cr-Commit-Position: refs/heads/master@{#31239}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 16, 2015
…erty loads. (patchset v8#3 id:100001 of https://codereview.chromium.org/1396333010/ ) Reason for revert: Waterfall redness. Original issue's description: > [turbofan] Initial support for monomorphic/polymorphic property loads. > > Native context specialization now lowers monomorphic and > polymorphic accesses to data and constant data properties on > object and/or prototype chain. We don't deal with accessors > yet, and we also completely ignore proxies (which is compatible > with what Crankshaft does). > > The code is more or less the straightforward implementation. We > will need to refactor that and extract common patterns once the > remaining bits for full load/store support is in. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel > [email protected] > BUG=v8:4470 > LOG=n > > Committed: https://crrev.com/3a0bf860b7177f7abef01ff308a53603389d958e > Cr-Commit-Position: refs/heads/master@{#31340} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Review URL: https://codereview.chromium.org/1408123002 Cr-Commit-Position: refs/heads/master@{#31341}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 20, 2015
…chset v8#3 id:40001 of https://codereview.chromium.org/1412133002/ ) Reason for revert: [sheriff] breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/4816 Original issue's description: > [es6] stage sticky regexps and RegExp.prototype.flags. > > [email protected] > BUG=v8:4342 > LOG=Y > > Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 > Cr-Commit-Position: refs/heads/master@{#31390} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342 Review URL: https://codereview.chromium.org/1403283004 Cr-Commit-Position: refs/heads/master@{#31398}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are derived from the following files within the Google V8
project:
test/mjsunit/es6/string-html.js